Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE

[Jocelyn Falempe <jfalempe@redhat.com>]

On 04/10/2024 01:07, Miguel Ojeda wrote:
> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
> 
>      ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>      >>> referenced by drm_panic.c
>      >>>               drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) in archive vmlinux.a
> 
> Thus select `CONFIG_ZLIB_DEFLATE`.

Hi, good catch, yes it should select the zlib deflate.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>

Best regards,

-- 

Jocelyn

> 
> Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
>   drivers/gpu/drm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1cb5a4f19293..cf5bc77e2362 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -152,6 +152,7 @@ config DRM_PANIC_SCREEN
>   config DRM_PANIC_SCREEN_QR_CODE
>   	bool "Add a panic screen with a QR code"
>   	depends on DRM_PANIC && RUST
> +	select ZLIB_DEFLATE
>   	help
>   	  This option adds a QR code generator, and a panic screen with a QR
>   	  code. The QR code will contain the last lines of kmsg and other debug
> --
> 2.46.2
>