From: Jocelyn Falempe <jfalempe@redhat.com>
To: Miguel Ojeda <ojeda@kernel.org>, David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE
Date: Mon, 14 Oct 2024 14:48:29 +0200 [thread overview]
Message-ID: <e8b90d70-d5dd-4ae9-8088-ca940d1fd9fa@redhat.com> (raw)
In-Reply-To: <609cf7e5-0fd6-4636-b5b1-b63fe319db28@redhat.com>
On 04/10/2024 09:14, Jocelyn Falempe wrote:
> On 04/10/2024 01:07, Miguel Ojeda wrote:
>> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
>>
>> ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>> >>> referenced by drm_panic.c
>> >>> drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init)
>> in archive vmlinux.a
>>
>> Thus select `CONFIG_ZLIB_DEFLATE`.
>
> Hi, good catch, yes it should select the zlib deflate.
>
> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
I've just pushed it to drm-misc-next.
Thanks for your contribution.
--
Jocelyn
>
> Best regards,
>
prev parent reply other threads:[~2024-10-14 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 23:07 [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE Miguel Ojeda
2024-10-04 7:14 ` Jocelyn Falempe
2024-10-14 12:48 ` Jocelyn Falempe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b90d70-d5dd-4ae9-8088-ca940d1fd9fa@redhat.com \
--to=jfalempe@redhat.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox