From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>
Cc: baolu.lu@linux.intel.com, Barak Biber <bbiber@nvidia.com>,
Joerg Roedel <jroedel@suse.de>, Kevin Tian <kevin.tian@intel.com>,
patches@lists.linux.dev
Subject: Re: [PATCH rc] iommu: Restore lost return in iommu_report_device_fault()
Date: Fri, 2 Aug 2024 08:30:57 +0800 [thread overview]
Message-ID: <c31ca390-b29b-4795-a223-a985ef62dc44@linux.intel.com> (raw)
In-Reply-To: <0-v1-e7153d9c8cee+1c6-iommu_fault_fix_jgg@nvidia.com>
On 2024/8/1 20:26, Jason Gunthorpe wrote:
> From: Barak Biber<bbiber@nvidia.com>
>
> When iommu_report_device_fault gets called with a partial fault it is
> supposed to collect the fault into the group and then return.
>
> Instead the return was accidently deleted which results in trying to
> process the fault and an eventual crash.
>
> Deleting the return was a typo, put it back.
>
> Fixes: 3dfa64aecbaf ("iommu: Make iommu_report_device_fault() return void")
> Signed-off-by: Barak Biber<bbiber@nvidia.com>
> Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Thanks,
baolu
next prev parent reply other threads:[~2024-08-02 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:26 [PATCH rc] iommu: Restore lost return in iommu_report_device_fault() Jason Gunthorpe
2024-08-02 0:30 ` Baolu Lu [this message]
2024-08-02 13:59 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c31ca390-b29b-4795-a223-a985ef62dc44@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=bbiber@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kevin.tian@intel.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox