* [PATCH rc] iommu: Restore lost return in iommu_report_device_fault()
@ 2024-08-01 12:26 Jason Gunthorpe
2024-08-02 0:30 ` Baolu Lu
2024-08-02 13:59 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2024-08-01 12:26 UTC (permalink / raw)
To: iommu, Joerg Roedel, Robin Murphy, Will Deacon
Cc: Lu Baolu, Barak Biber, Joerg Roedel, Kevin Tian, patches
From: Barak Biber <bbiber@nvidia.com>
When iommu_report_device_fault gets called with a partial fault it is
supposed to collect the fault into the group and then return.
Instead the return was accidently deleted which results in trying to
process the fault and an eventual crash.
Deleting the return was a typo, put it back.
Fixes: 3dfa64aecbaf ("iommu: Make iommu_report_device_fault() return void")
Signed-off-by: Barak Biber <bbiber@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/io-pgfault.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/io-pgfault.c b/drivers/iommu/io-pgfault.c
index cd679c13752e00..81e9cc6e3164a4 100644
--- a/drivers/iommu/io-pgfault.c
+++ b/drivers/iommu/io-pgfault.c
@@ -170,6 +170,7 @@ void iommu_report_device_fault(struct device *dev, struct iopf_fault *evt)
report_partial_fault(iopf_param, fault);
iopf_put_dev_fault_param(iopf_param);
/* A request that is not the last does not need to be ack'd */
+ return;
}
/*
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH rc] iommu: Restore lost return in iommu_report_device_fault()
2024-08-01 12:26 [PATCH rc] iommu: Restore lost return in iommu_report_device_fault() Jason Gunthorpe
@ 2024-08-02 0:30 ` Baolu Lu
2024-08-02 13:59 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Baolu Lu @ 2024-08-02 0:30 UTC (permalink / raw)
To: Jason Gunthorpe, iommu, Joerg Roedel, Robin Murphy, Will Deacon
Cc: baolu.lu, Barak Biber, Joerg Roedel, Kevin Tian, patches
On 2024/8/1 20:26, Jason Gunthorpe wrote:
> From: Barak Biber<bbiber@nvidia.com>
>
> When iommu_report_device_fault gets called with a partial fault it is
> supposed to collect the fault into the group and then return.
>
> Instead the return was accidently deleted which results in trying to
> process the fault and an eventual crash.
>
> Deleting the return was a typo, put it back.
>
> Fixes: 3dfa64aecbaf ("iommu: Make iommu_report_device_fault() return void")
> Signed-off-by: Barak Biber<bbiber@nvidia.com>
> Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Thanks,
baolu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH rc] iommu: Restore lost return in iommu_report_device_fault()
2024-08-01 12:26 [PATCH rc] iommu: Restore lost return in iommu_report_device_fault() Jason Gunthorpe
2024-08-02 0:30 ` Baolu Lu
@ 2024-08-02 13:59 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2024-08-02 13:59 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: iommu, Robin Murphy, Will Deacon, Lu Baolu, Barak Biber,
Joerg Roedel, Kevin Tian, patches
On Thu, Aug 01, 2024 at 09:26:04AM -0300, Jason Gunthorpe wrote:
> drivers/iommu/io-pgfault.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-02 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 12:26 [PATCH rc] iommu: Restore lost return in iommu_report_device_fault() Jason Gunthorpe
2024-08-02 0:30 ` Baolu Lu
2024-08-02 13:59 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox