* [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt()
@ 2016-10-17 14:56 Wei Yongjun
2016-10-18 2:22 ` Ley Foon Tan
2016-11-11 21:21 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-10-17 14:56 UTC (permalink / raw)
To: Ley Foon Tan, Bjorn Helgaas; +Cc: Wei Yongjun, rfi, linux-pci
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/pci/host/pcie-altera.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index b0ac4df..8be45a8 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -550,10 +550,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
pcie->cra_base = devm_ioremap_resource(dev, cra);
- if (IS_ERR(pcie->cra_base)) {
- dev_err(dev, "failed to map cra memory\n");
+ if (IS_ERR(pcie->cra_base))
return PTR_ERR(pcie->cra_base);
- }
/* setup IRQ */
pcie->irq = platform_get_irq(pdev, 0);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt()
2016-10-17 14:56 [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt() Wei Yongjun
@ 2016-10-18 2:22 ` Ley Foon Tan
2016-11-11 21:21 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Ley Foon Tan @ 2016-10-18 2:22 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Bjorn Helgaas, Wei Yongjun, Rocketboard Maillist, linux-pci
On Mon, Oct 17, 2016 at 10:56 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/pci/host/pcie-altera.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index b0ac4df..8be45a8 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -550,10 +550,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
>
> cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
> pcie->cra_base = devm_ioremap_resource(dev, cra);
> - if (IS_ERR(pcie->cra_base)) {
> - dev_err(dev, "failed to map cra memory\n");
> + if (IS_ERR(pcie->cra_base))
> return PTR_ERR(pcie->cra_base);
> - }
>
> /* setup IRQ */
> pcie->irq = platform_get_irq(pdev, 0);
>
Acked-by: Ley Foon Tan <lftan@altera.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt()
2016-10-17 14:56 [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt() Wei Yongjun
2016-10-18 2:22 ` Ley Foon Tan
@ 2016-11-11 21:21 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2016-11-11 21:21 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Ley Foon Tan, Bjorn Helgaas, Wei Yongjun, rfi, linux-pci
On Mon, Oct 17, 2016 at 02:56:13PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied with Ley Foon Tan's ack to pci/host-altera for v4.10, thanks!
> ---
> drivers/pci/host/pcie-altera.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index b0ac4df..8be45a8 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -550,10 +550,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
>
> cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
> pcie->cra_base = devm_ioremap_resource(dev, cra);
> - if (IS_ERR(pcie->cra_base)) {
> - dev_err(dev, "failed to map cra memory\n");
> + if (IS_ERR(pcie->cra_base))
> return PTR_ERR(pcie->cra_base);
> - }
>
> /* setup IRQ */
> pcie->irq = platform_get_irq(pdev, 0);
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-11 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 14:56 [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt() Wei Yongjun
2016-10-18 2:22 ` Ley Foon Tan
2016-11-11 21:21 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox