From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support
Date: Tue, 25 Feb 2025 14:21:01 +0100 [thread overview]
Message-ID: <1615a273-7a6f-4773-8c43-681e22ef661e@kernel.org> (raw)
In-Reply-To: <478b8972-07b9-483b-a3ef-bdea10c4e4cc@rock-chips.com>
On 25/02/2025 09:38, Kever Yang wrote:
>>>
>>> additionalProperties: true
>>>
>>> +anyOf:
>> There is never syntax like that. Where did you find it (so we can fix
>> it)?
... therefore please use existing code as examples instead of coming
with entirely new syntax.
>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: rockchip,rk3576-pcie
>> This does not belong to common schema, but to device specific. I don't
>> see this compatible in this common schema at all.
>
> The common schema covers rockchip-dw-pcie.yaml and rockchip-dw-pcie-ep.yaml,
>
> so I though I should add the if condition here.
You do not have compatibles here so you cannot add here code depending
on compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-25 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 7:49 [PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang
2025-02-24 9:28 ` Krzysztof Kozlowski
2025-02-25 8:38 ` Kever Yang
2025-02-25 13:21 ` Krzysztof Kozlowski [this message]
2025-02-24 9:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615a273-7a6f-4773-8c43-681e22ef661e@kernel.org \
--to=krzk@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox