* [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()
@ 2025-08-13 5:53 Nam Cao
2025-08-13 14:39 ` Wei Liu
2025-09-08 5:01 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Nam Cao @ 2025-08-13 5:53 UTC (permalink / raw)
To: K . Y . Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-hyperv,
linux-pci, linux-kernel
Cc: Nam Cao
The 'info' parameter of hv_msi_free() is unused. Delete it.
Signed-off-by: Nam Cao <namcao@linutronix.de>
---
drivers/pci/controller/pci-hyperv.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index d2b7e8ea710b..146b43981b27 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -1680,7 +1680,6 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
/**
* hv_msi_free() - Free the MSI.
* @domain: The interrupt domain pointer
- * @info: Extra MSI-related context
* @irq: Identifies the IRQ.
*
* The Hyper-V parent partition and hypervisor are tracking the
@@ -1688,8 +1687,7 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
* table up to date. This callback sends a message that frees
* the IRT entry and related tracking nonsense.
*/
-static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info,
- unsigned int irq)
+static void hv_msi_free(struct irq_domain *domain, unsigned int irq)
{
struct hv_pcibus_device *hbus;
struct hv_pci_dev *hpdev;
@@ -2181,10 +2179,8 @@ static int hv_pcie_domain_alloc(struct irq_domain *d, unsigned int virq, unsigne
static void hv_pcie_domain_free(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs)
{
- struct msi_domain_info *info = d->host_data;
-
for (int i = 0; i < nr_irqs; i++)
- hv_msi_free(d, info, virq + i);
+ hv_msi_free(d, virq + i);
irq_domain_free_irqs_top(d, virq, nr_irqs);
}
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()
2025-08-13 5:53 [PATCH] PCI: hv: Remove unused parameter of hv_msi_free() Nam Cao
@ 2025-08-13 14:39 ` Wei Liu
2025-09-08 5:01 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2025-08-13 14:39 UTC (permalink / raw)
To: Nam Cao
Cc: K . Y . Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-hyperv,
linux-pci, linux-kernel
On Wed, Aug 13, 2025 at 07:53:50AM +0200, Nam Cao wrote:
> The 'info' parameter of hv_msi_free() is unused. Delete it.
>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
Acked-by: Wei Liu <wei.liu@kernel.org>
I assume this will go through the PCI tree.
> ---
> drivers/pci/controller/pci-hyperv.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index d2b7e8ea710b..146b43981b27 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -1680,7 +1680,6 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
> /**
> * hv_msi_free() - Free the MSI.
> * @domain: The interrupt domain pointer
> - * @info: Extra MSI-related context
> * @irq: Identifies the IRQ.
> *
> * The Hyper-V parent partition and hypervisor are tracking the
> @@ -1688,8 +1687,7 @@ static void hv_int_desc_free(struct hv_pci_dev *hpdev,
> * table up to date. This callback sends a message that frees
> * the IRT entry and related tracking nonsense.
> */
> -static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info,
> - unsigned int irq)
> +static void hv_msi_free(struct irq_domain *domain, unsigned int irq)
> {
> struct hv_pcibus_device *hbus;
> struct hv_pci_dev *hpdev;
> @@ -2181,10 +2179,8 @@ static int hv_pcie_domain_alloc(struct irq_domain *d, unsigned int virq, unsigne
>
> static void hv_pcie_domain_free(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs)
> {
> - struct msi_domain_info *info = d->host_data;
> -
> for (int i = 0; i < nr_irqs; i++)
> - hv_msi_free(d, info, virq + i);
> + hv_msi_free(d, virq + i);
>
> irq_domain_free_irqs_top(d, virq, nr_irqs);
> }
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: hv: Remove unused parameter of hv_msi_free()
2025-08-13 5:53 [PATCH] PCI: hv: Remove unused parameter of hv_msi_free() Nam Cao
2025-08-13 14:39 ` Wei Liu
@ 2025-09-08 5:01 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2025-09-08 5:01 UTC (permalink / raw)
To: K . Y . Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring,
Bjorn Helgaas, linux-hyperv, linux-pci, linux-kernel, Nam Cao
On Wed, 13 Aug 2025 07:53:50 +0200, Nam Cao wrote:
> The 'info' parameter of hv_msi_free() is unused. Delete it.
>
>
Applied, thanks!
[1/1] PCI: hv: Remove unused parameter of hv_msi_free()
commit: ce47f81925ed73f9d27b1a01f07afdb031949c68
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-08 5:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 5:53 [PATCH] PCI: hv: Remove unused parameter of hv_msi_free() Nam Cao
2025-08-13 14:39 ` Wei Liu
2025-09-08 5:01 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox