From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
arnd@arndb.de, gregkh@linuxfoundation.org, bhelgaas@google.com,
daniel@riscstar.com, mohdayaa@qti.qualcomm.com,
lbiancon@qti.qualcomm.com, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver
Date: Mon, 17 Aug 2026 08:15:28 +0200 [thread overview]
Message-ID: <1ef02f41-a8a7-4dcc-873a-c6bd30a1ffec@kernel.org> (raw)
In-Reply-To: <d00b4b0f-5958-4c7d-9f80-7fb283ef90e6@riscstar.com>
On 14/08/2026 18:55, Alex Elder wrote:
> On 8/14/26 2:03 AM, Krzysztof Kozlowski wrote:
>> On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote:
>>> +static struct pci_driver tc9564_function_driver = {
>>> + .name = DRIVER_NAME,
>>> + .id_table = tc9564_function_id_table,
>>> + .probe = tc9564_function_probe,
>>> + .remove = tc9564_function_remove,
>>> + .driver = {
>>> + .name = DRIVER_NAME,
>>> + .owner = THIS_MODULE,
>>
>> You just copied some old driver. Why do you need this?
>
> What do you mean I "just copied some old driver"?
>
> I do now see that a PCI driver doesn't need to set it,
> because pci_register_driver() sets it automatically.
>
> I will remove that in the next version.
Old driver because we removed it 13 years ago from all drivers and only
a few left-overs were still hanging around.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-08-17 6:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 22:29 [PATCH 0/2] PCI: introduce TC9564 misc driver Alex Elder
2026-08-13 22:29 ` [PATCH 1/2] dt-bindings: misc: introduce pci1179,0220.yaml Alex Elder
2026-08-14 1:45 ` sashiko-bot
2026-08-14 16:55 ` Alex Elder
2026-08-14 7:01 ` Krzysztof Kozlowski
2026-08-14 16:55 ` Alex Elder
2026-08-17 6:18 ` Krzysztof Kozlowski
2026-08-15 20:46 ` Rob Herring (Arm)
2026-08-17 2:43 ` Rob Herring
2026-08-13 22:29 ` [PATCH 2/2] misc: tc9564: introduce base PCI driver Alex Elder
2026-08-14 1:11 ` Greg KH
2026-08-14 7:31 ` Arnd Bergmann
2026-08-14 16:55 ` Alex Elder
2026-08-14 16:55 ` Alex Elder
2026-08-14 1:59 ` sashiko-bot
2026-08-14 16:55 ` Alex Elder
2026-08-14 7:03 ` Krzysztof Kozlowski
2026-08-14 16:55 ` Alex Elder
2026-08-17 6:15 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ef02f41-a8a7-4dcc-873a-c6bd30a1ffec@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=daniel@riscstar.com \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lbiancon@qti.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mohdayaa@qti.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox