Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, bhelgaas@google.com,
	daniel@riscstar.com, mohdayaa@qti.qualcomm.com,
	lbiancon@qti.qualcomm.com, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: misc: introduce pci1179,0220.yaml
Date: Sun, 16 Aug 2026 21:43:17 -0500	[thread overview]
Message-ID: <20260817024317.GA32943-robh@kernel.org> (raw)
In-Reply-To: <20260813222943.1655453-2-elder@riscstar.com>

On Thu, Aug 13, 2026 at 05:29:41PM -0500, Alex Elder wrote:
> Define the binding for the Toshiba TC9564 PCI endpoint function device.
> The third downstream PCIe switch port within this chip has an embedded
> PCIe controller, and that implements two of these PCIe functions.

A better subject would be "dt-bindings: misc: Add Toshiba PC9564 
endpoint functon device".

> 
> Signed-off-by: Daniel Thompson <daniel@riscstar.com>
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
>  .../bindings/misc/pci1179,0220.yaml           | 150 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 156 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/pci1179,0220.yaml
> 
> diff --git a/Documentation/devicetree/bindings/misc/pci1179,0220.yaml b/Documentation/devicetree/bindings/misc/pci1179,0220.yaml
> new file mode 100644
> index 0000000000000..30a76f377eec8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/pci1179,0220.yaml
> @@ -0,0 +1,150 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/pci1179,0220.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba TC9564 internal PCI endpoint function
> +
> +maintainers:
> +  - Alex Elder <elder@kernel.org>
> +  - Daniel Thompson <danielt@kernel.org>
> +
> +description: >
> +  The Toshiba TC9564 is specialized SoC that implements a PCIe switch
> +  as well as an Ethernet AVB/TSN bridge.  In addition to these, the SoC
> +  implements other functions, including a reset and clock controller,
> +  an address translation unit, and a few other devices.
> +
> +  The PCI switch has three downstream ports.  The first two are exposed
> +  externally, while the third is used by an internal PCIe endpoint.  The
> +  internal endpoint implements two PCIe functions, and attached to each
> +  of these is a 10 Gbps capable Synopsys Ethernet controller and an
> +  interrupt controller that converts internal "wired" interrupts into
> +  MSIs delivered to the host.
> +
> +  PCIe BARs provide access to registers that manage almost all IP blocks.
> +  The SoC is modeled using a PCI endpoint bus.  The IP blocks are bound
> +  to platform drivers that access the hardware using MMIO through the
> +  PCI BARs.
> +
> +          ------------------------------------
> +          |               Host               |
> +          -----........---------------...-----
> +              |        |             |   |
> +              |  PCIe  |             |I2C|
> +              |        |             |   |
> +    ----------+........+-------------+...+---------------------------
> +    |         |upstream|          |          |     ---------------- |
> +    | Toshiba | Port 0 |          |          +-----+ PCIe pwrctrl | |
> +    | TC9564  ----++----          |   I2C    |     ---------------- |
> +    |  SoC        ||              |controller|     ---------------- |
> +    |             ||              |          +-----+     GPIO     | |
> +    |             ||              |          |     |  controller  | |
> +    |       ------++------        ------------     ---------------- |
> +    |       |     US     |                                          |
> +    |       |            |    ------------------------------------- |
> +    |       |         DS3+====+          downstream port 3        | |
> +    |       |            |    |-----------------------------------| |
> +    |       |    PCIe    |    |       embedded PCIe endpoint      | |
> +    |       |            |    |~~~~~~~~~~~~~~~~~+~~~~~~~~~~~~~~~~~| |
> +    |       |   Switch   |    | PCIe function 0 | PCIe function 1 | |
> +    |       |            |    |-----------------+-----------------| |
> +    |       |            |    |  BAR  | |  BAR  |         |  BAR  | |
> +    |       |            |    |   0   | |   4   |         |   4   | |
> +    |       | DS1    DS2 |    ----.---- ----.----         ----.---- |
> +    |       --++------++--        :      ...:                 :...  |
> +    |         ||      ||          :      :  :   -------       :  |  |
> +    |         ||      ||   -------.---  -.- :...|clock|       : -.- |
> +    |         ||      ||   |translate|  |M| :   -------       : |M| |
> +    |         ||      ||   -----------  |S| :                 : |S| |
> +    |         ||      ||                |I| :   -------       : |I| |
> +    |         ||      ||                |G| :...|reset|       : |G| |
> +    |         ||      ||                |E| :   -------       : |E| |
> +    | --------++--  --++--------        |N| :                 : |N| |
> +    | |downstream|  |downstream|      ------.----       ------.---- |
> +    | |  port 1  |  |  port 2  |      | XGMAC 0 |       | XGMAC 1 | |
> +    --+..........+--+..........+-------+.......+---------+.....+-----
> +                                      |       |          |     |
> +                                      |USXGMII|          |SGMII|
> +                                      |       |          |     |
> +                                    ---+.....+---      --+.....+--
> +                                    |  Ethernet |      | Ethernet|
> +                                    |    PHY    |      |   PHY   |
> +                                    -------------      -----------
> +
> +allOf:
> +  - $ref: /schemas/pci/pci-ep-bus.yaml
> +
> +properties:
> +  compatible:
> +    const: pci1179,0220 # Toshiba TC96564 (a.k.a. Qualcomm QPS615)

Perhaps somewhere besides a comment say what the relationship to a 
Qualcomm device is.

Rob

  parent reply	other threads:[~2026-08-17  2:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 22:29 [PATCH 0/2] PCI: introduce TC9564 misc driver Alex Elder
2026-08-13 22:29 ` [PATCH 1/2] dt-bindings: misc: introduce pci1179,0220.yaml Alex Elder
2026-08-14  1:45   ` sashiko-bot
2026-08-14 16:55     ` Alex Elder
2026-08-14  7:01   ` Krzysztof Kozlowski
2026-08-14 16:55     ` Alex Elder
2026-08-17  6:18       ` Krzysztof Kozlowski
2026-08-15 20:46   ` Rob Herring (Arm)
2026-08-17  2:43   ` Rob Herring [this message]
2026-08-13 22:29 ` [PATCH 2/2] misc: tc9564: introduce base PCI driver Alex Elder
2026-08-14  1:11   ` Greg KH
2026-08-14  7:31     ` Arnd Bergmann
2026-08-14 16:55       ` Alex Elder
2026-08-14 16:55     ` Alex Elder
2026-08-14  1:59   ` sashiko-bot
2026-08-14 16:55     ` Alex Elder
2026-08-14  7:03   ` Krzysztof Kozlowski
2026-08-14 16:55     ` Alex Elder
2026-08-17  6:15       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817024317.GA32943-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@riscstar.com \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@riscstar.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=lbiancon@qti.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mohdayaa@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox