From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] msi: Disable msi interrupts when we initialize a pci device
Date: Fri, 11 Nov 2011 09:58:14 -0800 [thread overview]
Message-ID: <20111111095814.4c3fc3c9@jbarnes-desktop> (raw)
In-Reply-To: <m1y5wj4ftd.fsf@fess.ebiederm.org>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Mon, 17 Oct 2011 11:46:06 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> I traced a nasty kexec on panic boot failure to the fact that we had
> screaming msi interrupts and we were not disabling the msi messages at
> kernel startup. The booting kernel had not enabled those interupts so
> was not prepared to handle them.
>
> I can see no reason why we would ever want to leave the msi interrupts
> enabled at boot if something else has enabled those interrupts. The pci
> spec specifies that msi interrupts should be off by default. Drivers
> are expected to enable the msi interrupts if they want to use them. Our
> interrupt handling code reprograms the interrupt handlers at boot and
> will not be be able to do anything useful with an unexpected interrupt.
>
> This patch applies cleanly all of the way back to 2.6.32 where I noticed
> the problem.
>
> Cc: stable@kernel.org
>
Applied to -next because I'm a chicken.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
parent reply other threads:[~2011-11-11 17:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <m1y5wj4ftd.fsf@fess.ebiederm.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111095814.4c3fc3c9@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=ebiederm@xmission.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox