Re: [PATCH] msi: Disable msi interrupts when we initialize a pci device

Re: [PATCH] msi: Disable msi interrupts when we initialize a pci device

[Jesse Barnes]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Mon, 17 Oct 2011 11:46:06 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:

> 
> I traced a nasty kexec on panic boot failure to the fact that we had
> screaming msi interrupts and we were not disabling the msi messages at
> kernel startup.  The booting kernel had not enabled those interupts so
> was not prepared to handle them.
> 
> I can see no reason why we would ever want to leave the msi interrupts
> enabled at boot if something else has enabled those interrupts.  The pci
> spec specifies that msi interrupts should be off by default.  Drivers
> are expected to enable the msi interrupts if they want to use them.  Our
> interrupt handling code reprograms the interrupt handlers at boot and
> will not be be able to do anything useful with an unexpected interrupt.
> 
> This patch applies cleanly all of the way back to 2.6.32 where I noticed
> the problem.
> 
> Cc: stable@kernel.org
> 

Applied to -next because I'm a chicken.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]