From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>,
linux-kernel@vger.kernel.org, Frederik Himpe <fhimpe@vub.ac.be>,
Oliver Neukum <oneukum@suse.de>,
David Haerdeman <david@hardeman.nu>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
Andy Grover <agrover@redhat.com>
Subject: Re: [PATCH] pci: do not try to assign irq 255
Date: Tue, 5 Mar 2013 14:41:50 -0800 [thread overview]
Message-ID: <20130305224150.GE8339@xanatos> (raw)
In-Reply-To: <51305B99.6080806@suse.de>
On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote:
> On 02/27/2013 10:13 PM, Bjorn Helgaas wrote:
> >[+cc Andy]
> >
> >3) I don't understand why the xhci init fails in the first place. It
> >looks like the "request interrupt 255 failed" message is from
> >xhci_try_enable_msi(), but that function tries to enable MSI-X, then
> >MSI, then falls back to legacy interrupts, where we get the error.
> >But the device supports MSI, so I don't know why we even fall back to
> >trying legacy interrupts. Hannes, do you have any insight into that?
> >Obviously I'm missing something here.
> >
> Hehe. Due to overly clever design.
> xhci actually sets up interrupts _twice_, once per request_irq() in
> the generic code and a second time during xhci_run.
> But as the first call fails it'll never ever run the second part.
>
> I'll be sending a patch.
Something like this?
http://marc.info/?l=linux-usb&m=132972894117916&w=2
(Apparently we had this issue around the same time last year, but we
thought the BIOS bug had been resolved.)
Sarah Sharp
next prev parent reply other threads:[~2013-03-05 22:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 10:09 [PATCH] pci: do not try to assign irq 255 Hannes Reinecke
2013-02-19 1:13 ` David Härdeman
2013-02-19 19:40 ` Yinghai Lu
2013-02-20 7:58 ` Hannes Reinecke
2013-02-20 16:57 ` Yinghai Lu
2013-02-21 6:53 ` Hannes Reinecke
2013-02-26 13:29 ` David Härdeman
2013-02-26 13:50 ` Hannes Reinecke
2013-02-27 21:13 ` Bjorn Helgaas
2013-02-28 16:13 ` Hannes Reinecke
2013-03-01 7:41 ` Hannes Reinecke
2013-03-05 22:41 ` Sarah Sharp [this message]
2013-03-26 21:54 ` Bjorn Helgaas
2013-03-26 23:34 ` Yinghai Lu
2013-09-10 21:53 ` Bjorn Helgaas
2013-02-19 19:47 ` Bjorn Helgaas
2013-02-19 22:36 ` Frederik Himpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305224150.GE8339@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=agrover@redhat.com \
--cc=bhelgaas@google.com \
--cc=david@hardeman.nu \
--cc=fhimpe@vub.ac.be \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox