Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH 3/5] PCI: Remove obsolete comment reference to pci_pcie_cap2()
Date: Tue, 27 Aug 2013 13:00:40 -0600	[thread overview]
Message-ID: <20130827190040.16595.42583.stgit@bhelgaas-glaptop> (raw)
In-Reply-To: <20130827185731.16595.52864.stgit@bhelgaas-glaptop>

pci_pcie_cap2() was replaced by pcie_capability_read_word() and similar
functions, so update the comment.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 include/uapi/linux/pci_regs.h |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 5bb33f4..591bb3b 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -544,10 +544,12 @@
 #define PCI_EXP_RTSTA_PME	0x10000 /* PME status */
 #define PCI_EXP_RTSTA_PENDING	0x20000 /* PME pending */
 /*
- * Note that the following PCI Express 'Capability Structure' registers
- * were introduced with 'Capability Version' 0x2 (v2).  These registers
- * do not exist on devices with Capability Version 1.  Use pci_pcie_cap2()
- * to use these fields safely.
+ * The Device Capabilities 2, Device Status 2, Device Control 2,
+ * Link Capabilities 2, Link Status 2, Link Control 2,
+ * Slot Capabilities 2, Slot Status 2, and Slot Control 2 registers
+ * are only present on devices with PCIe Capability version 2.
+ * Use pcie_capability_read_word() and similar interfaces to use them
+ * safely.
  */
 #define PCI_EXP_DEVCAP2		36	/* Device Capabilities 2 */
 #define  PCI_EXP_DEVCAP2_ARI		0x20	/* Alternative Routing-ID */


  parent reply	other threads:[~2013-08-27 19:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 19:00 [PATCH 0/5] PCIe capability #define tidyup Bjorn Helgaas
2013-08-27 19:00 ` [PATCH 1/5] PCI: Rename PCIe capability definitions to follow convention Bjorn Helgaas
2013-08-27 22:05   ` Samuel Ortiz
2013-08-27 19:00 ` [PATCH 2/5] PCI: Clarify PCI_EXP_TYPE_PCI_BRIDGE comment Bjorn Helgaas
2013-08-27 19:00 ` Bjorn Helgaas [this message]
2013-08-27 19:00 ` [PATCH 4/5] PCI: Tidy bitmasks and spacing of PCIe capability definitions Bjorn Helgaas
2013-08-27 19:00 ` [PATCH 5/5] PCI: Add offsets of PCIe capability registers Bjorn Helgaas
2013-08-29  3:15 ` [PATCH 0/5] PCIe capability #define tidyup Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827190040.16595.42583.stgit@bhelgaas-glaptop \
    --to=bhelgaas@google.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox