[PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[Bjorn Helgaas]

mvebu_pcie_align_resource() is only used inside pci-mvebu.c, so
make it static.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/host/pci-mvebu.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index 729d5a1..bf4ff23 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -673,11 +673,11 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
 	return bus;
 }
 
-resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
-					  const struct resource *res,
-					  resource_size_t start,
-					  resource_size_t size,
-					  resource_size_t align)
+static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
+						 const struct resource *res,
+						 resource_size_t start,
+						 resource_size_t size,
+						 resource_size_t align)
 {
 	if (dev->bus->number != 0)
 		return start;

Re: [PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[Thomas Petazzoni]

Dear Bjorn Helgaas,

On Mon, 07 Oct 2013 17:38:46 -0600, Bjorn Helgaas wrote:
> mvebu_pcie_align_resource() is only used inside pci-mvebu.c, so
> make it static.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

I'm obviously fine with that, but there is already a patch "[PATCH V2
2/3] PCI: mvebu: make local functions static" hanging around to do the
same.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[Bjorn Helgaas]

On Tue, Oct 8, 2013 at 1:21 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Bjorn Helgaas,
>
> On Mon, 07 Oct 2013 17:38:46 -0600, Bjorn Helgaas wrote:
>> mvebu_pcie_align_resource() is only used inside pci-mvebu.c, so
>> make it static.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I'm obviously fine with that, but there is already a patch "[PATCH V2
> 2/3] PCI: mvebu: make local functions static" hanging around to do the
> same.

OK, sorry for the duplication.  I dropped Jingoo's patch from
patchwork because Jason C. is merging mvebu stuff, and then it's "out
of sight, out of mind."

Bjorn

Re: [PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[Jason Cooper]

On Tue, Oct 08, 2013 at 10:07:52AM -0600, Bjorn Helgaas wrote:
> On Tue, Oct 8, 2013 at 1:21 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > Dear Bjorn Helgaas,
> >
> > On Mon, 07 Oct 2013 17:38:46 -0600, Bjorn Helgaas wrote:
> >> mvebu_pcie_align_resource() is only used inside pci-mvebu.c, so
> >> make it static.
> >>
> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> >
> > I'm obviously fine with that, but there is already a patch "[PATCH V2
> > 2/3] PCI: mvebu: make local functions static" hanging around to do the
> > same.
> 
> OK, sorry for the duplication.  I dropped Jingoo's patch from
> patchwork because Jason C. is merging mvebu stuff, and then it's "out
> of sight, out of mind."

Ok, I dug Jingoo's patch out of the Internet (it has everything!), and
applied it.  Unfortunately, I don't have the original email to reply
to, so this email will have to suffice.

Applied to mvebu/drivers

thx,

Jason.

Re: [PATCH] PCI: mvebu: Make mvebu_pcie_align_resource() static

[Jingoo Han]

On Wednesday, October 09, 2013 3:04 AM, Jason Cooper wrote:
> On Tue, Oct 08, 2013 at 10:07:52AM -0600, Bjorn Helgaas wrote:
> > On Tue, Oct 8, 2013 at 1:21 AM, Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> wrote:
> > > Dear Bjorn Helgaas,
> > >
> > > On Mon, 07 Oct 2013 17:38:46 -0600, Bjorn Helgaas wrote:
> > >> mvebu_pcie_align_resource() is only used inside pci-mvebu.c, so
> > >> make it static.
> > >>
> > >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > >
> > > I'm obviously fine with that, but there is already a patch "[PATCH V2
> > > 2/3] PCI: mvebu: make local functions static" hanging around to do the
> > > same.
> >
> > OK, sorry for the duplication.  I dropped Jingoo's patch from
> > patchwork because Jason C. is merging mvebu stuff, and then it's "out
> > of sight, out of mind."
> 
> Ok, I dug Jingoo's patch out of the Internet (it has everything!), and
> applied it.  Unfortunately, I don't have the original email to reply
> to, so this email will have to suffice.
> 
> Applied to mvebu/drivers
> 
Jason Cooper,
Thank you for accepting my patch. :-)

Bjorn Helgaas,
Thank you for sending patches for PCIe host drivers. :-)
It is very helpful.

Best regards,
Jingoo Han