Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Olof Johansson]

On Sun, Jul 20, 2014 at 05:29:47PM +0530, Viresh Kumar wrote:
> Following compilation warning occurs when compiled with:
> CONFIG_DEBUG_SECTION_MISMATCH=y
> 
>  WARNING: drivers/pci/host/built-in.o(.data+0xc0): Section mismatch in
>  reference from the variable spear13xx_pcie_driver to the function
>  .init.text:spear13xx_pcie_probe()
> 
> Both .probe() and pcie_init() are marked with __init, but spear13xx_pcie_driver
> isn't. And so section mismatch.
> 
> Fix it by marking spear13xx_pcie_driver with __initdata.
> 
> Fixes: 51b66a6 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx)

Please use 12 significant digits, since 7 might not be sufficient later
on in time. I've fixed it up here.

> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Olof/Arnd,
> 
> Let me know if a PULL request is required for this, otherwise just apply them
> directly.

I've applied both of these on top of next/drivers, where your previous branch
was. No need for a pull request.


-Olof

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Viresh Kumar]

On 21 July 2014 00:56, Olof Johansson <olof@lixom.net> wrote:
> Please use 12 significant digits, since 7 might not be sufficient later
> on in time. I've fixed it up here.

I surely didn't knew this and haven't seen other maintainers do this
as well.. And thought, whatever "git log --online" gives would be
enough.

Will take care of this in future.

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Olof Johansson]

On Sun, Jul 20, 2014 at 5:12 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 21 July 2014 00:56, Olof Johansson <olof@lixom.net> wrote:
>> Please use 12 significant digits, since 7 might not be sufficient later
>> on in time. I've fixed it up here.
>
> I surely didn't knew this and haven't seen other maintainers do this
> as well.. And thought, whatever "git log --online" gives would be
> enough.
>
> Will take care of this in future.

Oh, sorry, I got distracted by my kid waking up so the email was a bit short. :)

The easiest way of doing it is to switch to 12 by default. In your .gitconfig:

[core]
        abbrev = 12


-Olof

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Viresh Kumar]

On 21 July 2014 05:51, Olof Johansson <olof@lixom.net> wrote:
> Oh, sorry, I got distracted by my kid waking up so the email was a bit short. :)

I can understand, mine is 14 months :)

> The easiest way of doing it is to switch to 12 by default. In your .gitconfig:
>
> [core]
>         abbrev = 12

Oh, that will be extremely useful. Thanks.

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Rob Herring]

On Sun, Jul 20, 2014 at 7:12 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 21 July 2014 00:56, Olof Johansson <olof@lixom.net> wrote:
>> Please use 12 significant digits, since 7 might not be sufficient later
>> on in time. I've fixed it up here.
>
> I surely didn't knew this and haven't seen other maintainers do this
> as well.. And thought, whatever "git log --online" gives would be
> enough.

The Fixes tag is new and the format is documented in SubmittingPatches
IIRC. I believe it is also supposed to be quotes rather than
parentheses around the commit message if we want to be really picky.

Rob

Re: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()

[Viresh Kumar]

On 21 July 2014 07:45, Rob Herring <robherring2@gmail.com> wrote:
> The Fixes tag is new and the format is documented in SubmittingPatches

Yeah, just saw that for the first time :)

> IIRC. I believe it is also supposed to be quotes rather than
> parentheses around the commit message if we want to be really picky.

Actually both: ("$subject")

I never saw the doc and picked how it was done by Rafael for cpufreq stuff.
Though he was correctly adding 12 digits of the sha key, but the quotes
were missing :)

I will take care of this now.

--
viresh