From: Bjorn Helgaas <bhelgaas@google.com>
To: Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH v2 0/5] PCI: iproc: Cleanups
Date: Wed, 12 Oct 2016 07:53:03 -0500 [thread overview]
Message-ID: <20161012124804.24076.48957.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
- Add local "dev" pointers to reduce repetition of things like
"&pdev->dev".
- Tidy up drvdata usage.
- Remove some null pointer checking after adding corresponding checking
elsewhere.
- Hard-code the PCIe capability offset instead of searching for it. This
removes a little bit of dependency on struct pci_bus, with an eye
toward moving the link maintenance before enumeration.
Changes from v1:
I dropped the following patches because they were a lot of churn for
questionable benefit:
PCI: iproc: Rename accessors
PCI: iproc: Name private struct pointer "iproc" consistently
---
Bjorn Helgaas (5):
PCI: iproc: Add local struct device pointers
PCI: iproc: Set drvdata at end of probe function
PCI: iproc: Validate CSR base in BCMA setup code
PCI: iproc: Remove redundant null pointer checking
PCI: iproc: Hard-code PCIe capability offset instead of searching
drivers/pci/host/pcie-iproc-bcma.c | 14 ++++++---
drivers/pci/host/pcie-iproc-platform.c | 27 +++++++++--------
drivers/pci/host/pcie-iproc.c | 52 ++++++++++++++++----------------
3 files changed, 50 insertions(+), 43 deletions(-)
next reply other threads:[~2016-10-12 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:53 Bjorn Helgaas [this message]
2016-10-12 12:53 ` [PATCH v2 1/5] PCI: iproc: Add local struct device pointers Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 2/5] PCI: iproc: Set drvdata at end of probe function Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 3/5] PCI: iproc: Validate CSR base in BCMA setup code Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 4/5] PCI: iproc: Remove redundant null pointer checking Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 5/5] PCI: iproc: Hard-code PCIe capability offset instead of searching Bjorn Helgaas
2016-10-12 16:01 ` [PATCH v2 0/5] PCI: iproc: Cleanups Bjorn Helgaas
2016-10-12 16:04 ` Ray Jui
2016-10-12 16:18 ` Bjorn Helgaas
2016-10-17 22:02 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012124804.24076.48957.stgit@bhelgaas-glaptop2.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jonmason@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox