From: Ray Jui <ray.jui@broadcom.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 0/5] PCI: iproc: Cleanups
Date: Wed, 12 Oct 2016 09:04:26 -0700 [thread overview]
Message-ID: <4e1e4df1-15b0-7deb-eaa9-4ac683812be9@broadcom.com> (raw)
In-Reply-To: <20161012160114.GC4308@localhost>
Hi Bjorn,
On 10/12/2016 9:01 AM, Bjorn Helgaas wrote:
> On Wed, Oct 12, 2016 at 07:53:03AM -0500, Bjorn Helgaas wrote:
>> - Add local "dev" pointers to reduce repetition of things like
>> "&pdev->dev".
>>
>> - Tidy up drvdata usage.
>>
>> - Remove some null pointer checking after adding corresponding checking
>> elsewhere.
>>
>> - Hard-code the PCIe capability offset instead of searching for it. This
>> removes a little bit of dependency on struct pci_bus, with an eye
>> toward moving the link maintenance before enumeration.
>>
>> Changes from v1:
>> I dropped the following patches because they were a lot of churn for
>> questionable benefit:
>> PCI: iproc: Rename accessors
>> PCI: iproc: Name private struct pointer "iproc" consistently
>>
>> ---
>>
>> Bjorn Helgaas (5):
>> PCI: iproc: Add local struct device pointers
>> PCI: iproc: Set drvdata at end of probe function
>> PCI: iproc: Validate CSR base in BCMA setup code
>> PCI: iproc: Remove redundant null pointer checking
>> PCI: iproc: Hard-code PCIe capability offset instead of searching
>
> I applied these to pci/host-iproc for v4.9. I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.
>
That sounds good. Are these patches in the git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git at branch
pci/host-iproc?
I plan to sanity test them on various iProc based SoCs.
Thanks,
Ray
next prev parent reply other threads:[~2016-10-12 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:53 [PATCH v2 0/5] PCI: iproc: Cleanups Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 1/5] PCI: iproc: Add local struct device pointers Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 2/5] PCI: iproc: Set drvdata at end of probe function Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 3/5] PCI: iproc: Validate CSR base in BCMA setup code Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 4/5] PCI: iproc: Remove redundant null pointer checking Bjorn Helgaas
2016-10-12 12:53 ` [PATCH v2 5/5] PCI: iproc: Hard-code PCIe capability offset instead of searching Bjorn Helgaas
2016-10-12 16:01 ` [PATCH v2 0/5] PCI: iproc: Cleanups Bjorn Helgaas
2016-10-12 16:04 ` Ray Jui [this message]
2016-10-12 16:18 ` Bjorn Helgaas
2016-10-17 22:02 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e1e4df1-15b0-7deb-eaa9-4ac683812be9@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonmason@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox