Re: [PATCH v2 0/5] PCI: exynos: Cleanups

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Oct 12, 2016 at 08:37:07AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Name private struct pointer consistently within driver.
> 
>   - Pass device-specific struct to internal functions for consistency.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: exynos: Name private struct pointer "exynos" consistently
>       (Instead of renaming *all* the pointers, I only renamed enough to
>       make them consistent within this file.)
>     PCI: exynos: Swap order of exynos_elb_writel() reg/val arguments
>     PCI: exynos: Swap order of exynos_phy_writel() reg/val arguments
>     PCI: exynos: Swap order of exynos_blk_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (5):
>       PCI: exynos: Add local struct device pointers
>       PCI: exynos: Uninline register accessors
>       PCI: exynos: Name private struct pointer "exynos_pcie" consistently
>       PCI: exynos: Pass device-specific struct to internal functions
>       PCI: exynos: Reorder struct exynos_pcie
> 
> 
>  drivers/pci/host/pci-exynos.c |  214 +++++++++++++++++++----------------------
>  1 file changed, 100 insertions(+), 114 deletions(-)

I applied these to pci/host-exynos for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.