Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain
Date: Mon, 7 Nov 2016 13:19:24 +0100	[thread overview]
Message-ID: <20161107121924.GA12319@verge.net.au> (raw)
In-Reply-To: <1478520048-25430-1-git-send-email-horms+renesas@verge.net.au>

On Mon, Nov 07, 2016 at 01:00:48PM +0100, Simon Horman wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> 
> Phil, this is from the 3.3.2 BSP.
> Is it appropriate for mainline?

I see there is also an infrastructure patch (by you) required for this
change: one to add pci_fixup_irqs_local(). I'll hold off on posting that
pending your answer to the question above.

> ---
>  drivers/pci/host/pcie-rcar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 62700d1896f4..06e7a75094c7 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -472,7 +472,7 @@ static int rcar_pcie_enable(struct rcar_pcie *pcie)
>  		return -ENODEV;
>  	}
>  
> -	pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> +	pci_fixup_irqs_local(bus, pci_common_swizzle, of_irq_parse_and_map_pci);
>  
>  	pci_bus_size_bridges(bus);
>  	pci_bus_assign_resources(bus);
> -- 
> 2.7.0.rc3.207.g0ac5344
> 

  reply	other threads:[~2016-11-07 12:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 12:00 [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain Simon Horman
2016-11-07 12:19 ` Simon Horman [this message]
2016-11-07 13:32 ` Phil Edworthy
2016-11-07 13:38   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107121924.GA12319@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=phil.edworthy@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox