* [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain
@ 2016-11-07 12:00 Simon Horman
2016-11-07 12:19 ` Simon Horman
2016-11-07 13:32 ` Phil Edworthy
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2016-11-07 12:00 UTC (permalink / raw)
To: Phil Edworthy; +Cc: Magnus Damm, linux-pci, linux-renesas-soc, Simon Horman
From: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Phil, this is from the 3.3.2 BSP.
Is it appropriate for mainline?
---
drivers/pci/host/pcie-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 62700d1896f4..06e7a75094c7 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -472,7 +472,7 @@ static int rcar_pcie_enable(struct rcar_pcie *pcie)
return -ENODEV;
}
- pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
+ pci_fixup_irqs_local(bus, pci_common_swizzle, of_irq_parse_and_map_pci);
pci_bus_size_bridges(bus);
pci_bus_assign_resources(bus);
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain
2016-11-07 12:00 [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain Simon Horman
@ 2016-11-07 12:19 ` Simon Horman
2016-11-07 13:32 ` Phil Edworthy
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-11-07 12:19 UTC (permalink / raw)
To: Phil Edworthy; +Cc: Magnus Damm, linux-pci, linux-renesas-soc
On Mon, Nov 07, 2016 at 01:00:48PM +0100, Simon Horman wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> Phil, this is from the 3.3.2 BSP.
> Is it appropriate for mainline?
I see there is also an infrastructure patch (by you) required for this
change: one to add pci_fixup_irqs_local(). I'll hold off on posting that
pending your answer to the question above.
> ---
> drivers/pci/host/pcie-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 62700d1896f4..06e7a75094c7 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -472,7 +472,7 @@ static int rcar_pcie_enable(struct rcar_pcie *pcie)
> return -ENODEV;
> }
>
> - pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> + pci_fixup_irqs_local(bus, pci_common_swizzle, of_irq_parse_and_map_pci);
>
> pci_bus_size_bridges(bus);
> pci_bus_assign_resources(bus);
> --
> 2.7.0.rc3.207.g0ac5344
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain
2016-11-07 12:00 [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain Simon Horman
2016-11-07 12:19 ` Simon Horman
@ 2016-11-07 13:32 ` Phil Edworthy
2016-11-07 13:38 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Phil Edworthy @ 2016-11-07 13:32 UTC (permalink / raw)
To: Simon Horman
Cc: Magnus Damm, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hi Simon,
On 07 November 2016 12:01, Simon Horman wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
>=20
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>=20
> Phil, this is from the 3.3.2 BSP.
> Is it appropriate for mainline?
No, this is not for upstream. The pci_fixup_irqs_local function was an RFC
that should be solved in a more generic way.
See https://patchwork.kernel.org/patch/9220653
BR
Phil
> ---
> drivers/pci/host/pcie-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 62700d1896f4..06e7a75094c7 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -472,7 +472,7 @@ static int rcar_pcie_enable(struct rcar_pcie *pcie)
> return -ENODEV;
> }
>=20
> - pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> + pci_fixup_irqs_local(bus, pci_common_swizzle,
> of_irq_parse_and_map_pci);
>=20
> pci_bus_size_bridges(bus);
> pci_bus_assign_resources(bus);
> --
> 2.7.0.rc3.207.g0ac5344
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain
2016-11-07 13:32 ` Phil Edworthy
@ 2016-11-07 13:38 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-11-07 13:38 UTC (permalink / raw)
To: Phil Edworthy
Cc: Magnus Damm, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
On Mon, Nov 07, 2016 at 01:32:28PM +0000, Phil Edworthy wrote:
> Hi Simon,
>
> On 07 November 2016 12:01, Simon Horman wrote:
> > From: Phil Edworthy <phil.edworthy@renesas.com>
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >
> > Phil, this is from the 3.3.2 BSP.
> > Is it appropriate for mainline?
> No, this is not for upstream. The pci_fixup_irqs_local function was an RFC
> that should be solved in a more generic way.
> See https://patchwork.kernel.org/patch/9220653
Thanks, got it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-07 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 12:00 [PATCH/RFC] PCI: rcar: Restrict pci_fixup_irqs to the same PCI domain Simon Horman
2016-11-07 12:19 ` Simon Horman
2016-11-07 13:32 ` Phil Edworthy
2016-11-07 13:38 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox