Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: Fix compile error with DPC disabled
Date: Fri, 21 Sep 2018 11:50:33 -0600	[thread overview]
Message-ID: <20180921175033.GA1731@localhost.localdomain> (raw)
In-Reply-To: <20180921171903.GL224714@bhelgaas-glaptop.roam.corp.google.com>

On Fri, Sep 21, 2018 at 12:19:03PM -0500, Bjorn Helgaas wrote:
> On Fri, Sep 21, 2018 at 11:02:34AM -0600, Keith Busch wrote:
> > On Fri, Sep 21, 2018 at 11:57:29AM -0500, Bjorn Helgaas wrote:
> > > On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote:
> > > > The alternate functions when CONFIG_PCIE_DPC is not defined need to be
> > > > static inline.
> > > > 
> > > > Signed-off-by: Keith Busch <keith.busch@intel.com>
> > > 
> > > If you tell me which patch, I'll fold this into it so there's no bisection
> > > hole.
> > 
> > Thanks, I like that plan.
> > 
> > Fixes: d17964c0d81fc38c7 ("PCI/DPC: Save and restore config state")
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/hotplug&id=d17964c0d81fc38c733fc5281436d2b262306a33
> 
> Done, sorry to bother you, I could have figured that out in 10 seconds
> myself from the 0-day robot email.

Oh, no problem at all. The breakage was my mistake, so my apologies. I
don't like getting caught by 0-day, but I'm happy it's there! :)

      reply	other threads:[~2018-09-21 17:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 14:22 [PATCH] PCI: Fix compile error with DPC disabled Keith Busch
2018-09-21 16:57 ` Bjorn Helgaas
2018-09-21 17:02   ` Keith Busch
2018-09-21 17:19     ` Bjorn Helgaas
2018-09-21 17:50       ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921175033.GA1731@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox