From: Andrew Murray <andrew.murray@arm.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/PCI: Remove surplus return from a void function
Date: Tue, 20 Aug 2019 10:34:16 +0100 [thread overview]
Message-ID: <20190820093415.GF23903@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190820065121.16594-1-kw@linux.com>
On Tue, Aug 20, 2019 at 08:51:21AM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary empty return statement at the end of a void
> function in the arch/x86/kernel/quirks.c.
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
> arch/x86/kernel/quirks.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
> index 8451f38ad399..1daf8f2aa21f 100644
> --- a/arch/x86/kernel/quirks.c
> +++ b/arch/x86/kernel/quirks.c
> @@ -90,8 +90,6 @@ static void ich_force_hpet_resume(void)
> BUG();
> else
> printk(KERN_DEBUG "Force enabled HPET at resume\n");
> -
> - return;
> }
>
> static void ich_force_enable_hpet(struct pci_dev *dev)
> @@ -448,7 +446,6 @@ static void nvidia_force_enable_hpet(struct pci_dev *dev)
> dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at 0x%lx\n",
> force_hpet_address);
> cached_dev = dev;
> - return;
> }
>
> /* ISA Bridges */
> @@ -513,7 +510,6 @@ static void e6xx_force_enable_hpet(struct pci_dev *dev)
> force_hpet_resume_type = NONE_FORCE_HPET_RESUME;
> dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
> "0x%lx\n", force_hpet_address);
> - return;
> }
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E6XX_CU,
> e6xx_force_enable_hpet);
> --
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> 2.22.1
>
next prev parent reply other threads:[~2019-08-20 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 6:51 [PATCH] x86/PCI: Remove surplus return from a void function Krzysztof Wilczynski
2019-08-20 9:34 ` Andrew Murray [this message]
2019-08-23 1:36 ` [tip: x86/cleanups] x86/PCI: Remove superfluous returns from void functions tip-bot2 for Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820093415.GF23903@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox