From: Andrew Murray <andrew.murray@arm.com>
To: Yurii Monakov <monakov.y@gmail.com>
Cc: linux-pci@vger.kernel.org, m-karicheri2@ti.com
Subject: Re: [PATCH] PCI: keystone: Fix outbound region mapping
Date: Mon, 16 Dec 2019 12:03:14 +0000 [thread overview]
Message-ID: <20191216120314.GU24359@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191004163723.GA31823@monakov-y.office.kontur-niirs.ru>
On Fri, Oct 04, 2019 at 07:37:23PM +0300, Yurii Monakov wrote:
> > This looks fine, however are the earlier lines still correct?
> Yes, according to TI Keystone PCIe datasheet pg. 3-10 OB_SIZE
> register should hold log2 of actual window size in MB (bits 2-0):
>
> 0h = 1MB
> 1h = 2MB
> 2h = 4MB
> 3h = 8MB
>
> But OB_OFFSET_INDEXn/OB_OFFSETn_HI register pair hold absolute
> 64-bit bus address, so 'start' variable sholud be incremented
> by 8M to map all PCIe data space (according to the comment above
> the loop).
>
> TI confirms this bug for for kernel v4.14, but since then
> some driver code relocation happend and I've decided to
> report this here.
Thanks for this, I'll add:
Fixes: e75043ad9792 ("PCI: keystone: Cleanup outbound window configuration")
Acked-by: Andrew Murray <andrew.murray@arm.com>
>
> Regards,
> Yurii
>
next prev parent reply other threads:[~2019-12-16 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:48 [PATCH] PCI: keystone: Fix outbound region mapping Yurii Monakov
2019-10-04 16:05 ` Andrew Murray
2019-10-04 16:37 ` Yurii Monakov
2019-12-16 12:03 ` Andrew Murray [this message]
2019-12-17 14:31 ` Bjorn Helgaas
2019-12-17 16:31 ` Yurii Monakov
2019-12-17 21:54 ` Bjorn Helgaas
2019-12-18 13:31 ` Yurii Monakov
2019-12-19 11:21 ` Kishon Vijay Abraham I
2020-01-10 17:33 ` Lorenzo Pieralisi
-- strict thread matches above, loose matches on Subject: below --
2019-10-04 15:16 Yurii Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216120314.GU24359@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=monakov.y@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox