From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Shmuel Hazan" <sh@tkos.co.il>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marek Behún" <marek.behun@nic.cz>,
"Baruch Siach" <baruch@tkos.co.il>,
"Chris ackham" <chris.packham@alliedtelesis.co.nz>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mvebu: setup BAR0 to internal-regs
Date: Mon, 22 Jun 2020 20:40:33 +0200 [thread overview]
Message-ID: <20200622204033.72055de8@windsurf.home> (raw)
In-Reply-To: <20200622172516.GA2290205@bjorn-Precision-5520>
Hello,
On Mon, 22 Jun 2020 12:25:16 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:
> > As a result of the requirement above, without this patch, MSI won't
> > function and therefore some devices won't operate properly without
> > pci=nomsi.
>
> Does that mean MSIs never worked at all with mvebu?
They definitely worked. I think what happens is that this register was
normally setup by the vendor-specific bootloader, and thanks to
firmware initialization, Linux had MSIs working properly.
With other bootloaders that initialize the PCIe block differently, or
even not at all, it became clear this init was missing in Linux.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-22 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 5:30 [PATCH] PCI: mvebu: setup BAR0 to internal-regs Shmuel Hazan
2020-06-22 17:25 ` Bjorn Helgaas
2020-06-22 18:40 ` Thomas Petazzoni [this message]
2020-06-22 22:49 ` Bjorn Helgaas
2020-06-23 4:31 ` Shmuel H.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622204033.72055de8@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=helgaas@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=sh@tkos.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox