Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Prike Liang" <Prike.Liang@amd.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rajat Jain" <rajatja@google.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: fix unused variable warning
Date: Fri, 30 Apr 2021 12:57:23 -0500	[thread overview]
Message-ID: <20210430175723.GA664165@bjorn-Precision-5520> (raw)
In-Reply-To: <20210421140436.3882411-1-arnd@kernel.org>

On Wed, Apr 21, 2021 at 04:04:20PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The function was introduced with a variable that is never referenced:
> 
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
> 
> Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")

I guess this refers to https://lore.kernel.org/linux-nvme/1618458725-17164-1-git-send-email-Prike.Liang@amd.com/

But I don't know what the SHA1 means; I can't find it in linux-next or
my tree.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/pci/quirks.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 2e24dced699a..c86ede081534 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -309,8 +309,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD,	PCI_DEVICE_ID_AMD_8151_0,	quirk_nopci
>  
>  static void quirk_amd_nvme_fixup(struct pci_dev *dev)
>  {
> -	struct pci_dev *rdev;
> -
>  	dev->dev_flags |= PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND;
>  	pci_info(dev, "AMD simple suspend opt enabled\n");
>  
> -- 
> 2.29.2
> 

  parent reply	other threads:[~2021-04-30 17:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 14:04 [PATCH] nvme: fix unused variable warning Arnd Bergmann
2021-04-21 16:57 ` Krzysztof Wilczyński
2021-04-30 17:57 ` Bjorn Helgaas [this message]
2021-04-30 18:34   ` Andy Shevchenko
2021-04-30 19:00     ` Bjorn Helgaas
2021-04-30 19:23       ` Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210430175723.GA664165@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=Prike.Liang@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rajatja@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox