From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Prike Liang" <Prike.Liang@amd.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rajat Jain" <rajatja@google.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-pci <linux-pci@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: fix unused variable warning
Date: Fri, 30 Apr 2021 14:00:57 -0500 [thread overview]
Message-ID: <20210430190057.GA671619@bjorn-Precision-5520> (raw)
In-Reply-To: <CAHp75Vchfem1OmR=2Mawiebw-zisU57BEcF64PUKcOODeiLS-g@mail.gmail.com>
On Fri, Apr 30, 2021 at 09:34:55PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 30, 2021 at 8:57 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Wed, Apr 21, 2021 at 04:04:20PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The function was introduced with a variable that is never referenced:
> > >
> > > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > > drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
> > >
> > > Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
> >
> > I guess this refers to https://lore.kernel.org/linux-nvme/1618458725-17164-1-git-send-email-Prike.Liang@amd.com/
> >
> > But I don't know what the SHA1 means; I can't find it in linux-next or
> > my tree.
>
> $ git tag --contains 9597624ef606
> next-20210416
> next-20210419
> next-20210420
>
> Something is wrong with your tree.
I think what's wrong is that it doesn't appear in the *current*
linux-next (next-20210430) and I don't have all the old linux-next
objects.
It was in next-20210420, but seems to have been dropped since then:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/linux/pci.h?h=next-20210420&id=9597624ef6067bab1500d0273a43d4f90e62e929
next prev parent reply other threads:[~2021-04-30 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 14:04 [PATCH] nvme: fix unused variable warning Arnd Bergmann
2021-04-21 16:57 ` Krzysztof Wilczyński
2021-04-30 17:57 ` Bjorn Helgaas
2021-04-30 18:34 ` Andy Shevchenko
2021-04-30 19:00 ` Bjorn Helgaas [this message]
2021-04-30 19:23 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430190057.GA671619@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alexander.deucher@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kai.heng.feng@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox