From: "Krzysztof Wilczyński" <kw@linux.com>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v2] PCI/portdrv: Use link bandwidth notification capability bit
Date: Fri, 14 May 2021 15:03:03 +0200 [thread overview]
Message-ID: <20210514130303.GD9537@rocinante.localdomain> (raw)
In-Reply-To: <20210512213314.7778-1-stuart.w.hayes@gmail.com>
Hi Stuart,
> The pcieport driver can fail to attach to a downstream port that doesn't
> support bandwidth notification. This can happen when, in
> pcie_port_device_register(), pci_init_service_irqs() tries (and fails) to
> set up a bandwidth notification IRQ for a device that doesn't support it.
>
> This patch changes get_port_device_capability() to look at the link
> bandwidth notification capability bit in the link capabilities register of
> the port, instead of assuming that all downstream ports have that
> capability.
[...]
Thank you for fixing this!
I was wondering - is this fix connected to an issue filled in Bugzilla
or does it fix a known commit that introduced this problem? Basically,
I am trying to see whether a "Fixes:" would be in order.
Krzysztof
next prev parent reply other threads:[~2021-05-14 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 21:33 [PATCH v2] PCI/portdrv: Use link bandwidth notification capability bit Stuart Hayes
2021-05-14 13:03 ` Krzysztof Wilczyński [this message]
2021-05-14 13:08 ` Lukas Wunner
2021-05-14 13:17 ` Krzysztof Wilczy??ski
2021-05-27 1:12 ` stuart hayes
2021-07-07 15:48 ` stuart hayes
2021-07-07 18:59 ` Bjorn Helgaas
2021-08-31 19:20 ` Bjorn Helgaas
2021-08-31 21:39 ` stuart hayes
2021-08-31 21:58 ` Bjorn Helgaas
2021-09-01 5:48 ` Lukas Wunner
2021-09-01 21:28 ` Bjorn Helgaas
2021-07-16 21:56 ` Bjorn Helgaas
2021-07-17 2:43 ` stuart hayes
2021-08-31 19:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514130303.GD9537@rocinante.localdomain \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox