From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: <hch@infradead.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <linux-pci@vger.kernel.org>,
<bhelgaas@google.com>
Cc: <stefanha@redhat.com>, <oren@nvidia.com>, <kw@linux.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
Date: Mon, 4 Oct 2021 16:34:53 +0300 [thread overview]
Message-ID: <20211004133453.18881-2-mgurtovoy@nvidia.com> (raw)
In-Reply-To: <20211004133453.18881-1-mgurtovoy@nvidia.com>
Use the proper macro instead of hard-coded (-1) value.
Suggested-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/pci/pci-sysfs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 7fb5cd17cc98..f807b92afa6c 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
const struct cpumask *mask;
#ifdef CONFIG_NUMA
- mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
- cpumask_of_node(dev_to_node(dev));
+ if (dev_to_node(dev) == NUMA_NO_NODE)
+ mask = cpu_online_mask;
+ else
+ mask = cpumask_of_node(dev_to_node(dev));
#else
mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
#endif
--
2.18.1
next prev parent reply other threads:[~2021-10-04 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:34 [PATCH v3 1/2] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-10-04 13:34 ` Max Gurtovoy [this message]
2021-10-04 19:04 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Krzysztof Wilczyński
2021-10-08 22:25 ` Bjorn Helgaas
2021-10-10 8:36 ` Max Gurtovoy
2021-10-11 14:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004133453.18881-2-mgurtovoy@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox