From: Bjorn Helgaas <helgaas@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
hch@infradead.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
stefanha@redhat.com, oren@nvidia.com, kw@linux.com
Subject: Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
Date: Mon, 11 Oct 2021 09:06:17 -0500 [thread overview]
Message-ID: <20211011140617.GA1643826@bhelgaas> (raw)
In-Reply-To: <a947cd7e-c847-4d44-5a65-51bbdceb1a1d@nvidia.com>
On Sun, Oct 10, 2021 at 11:36:49AM +0300, Max Gurtovoy wrote:
>
> On 10/9/2021 1:25 AM, Bjorn Helgaas wrote:
> > On Mon, Oct 04, 2021 at 04:34:53PM +0300, Max Gurtovoy wrote:
> > > Use the proper macro instead of hard-coded (-1) value.
> > >
> > > Suggested-by: Krzysztof Wilczyński <kw@linux.com>
> > > Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > These two patches are independent, so I applied this patch only to
> > pci/sysfs for v5.16, thanks!
> >
> > I assume Greg will take the drivers/base patch.
>
> I saw both patches in his
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-next
>
> So I guess there is no need for taking it separately, right Greg ?
No problem, I dropped the pci-sysfs.c patch. Thanks for letting me
know!
> > > ---
> > > drivers/pci/pci-sysfs.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> > > index 7fb5cd17cc98..f807b92afa6c 100644
> > > --- a/drivers/pci/pci-sysfs.c
> > > +++ b/drivers/pci/pci-sysfs.c
> > > @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
> > > const struct cpumask *mask;
> > > #ifdef CONFIG_NUMA
> > > - mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> > > - cpumask_of_node(dev_to_node(dev));
> > > + if (dev_to_node(dev) == NUMA_NO_NODE)
> > > + mask = cpu_online_mask;
> > > + else
> > > + mask = cpumask_of_node(dev_to_node(dev));
> > > #else
> > > mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
> > > #endif
> > > --
> > > 2.18.1
> > >
prev parent reply other threads:[~2021-10-11 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:34 [PATCH v3 1/2] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-10-04 13:34 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
2021-10-04 19:04 ` Krzysztof Wilczyński
2021-10-08 22:25 ` Bjorn Helgaas
2021-10-10 8:36 ` Max Gurtovoy
2021-10-11 14:06 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011140617.GA1643826@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox