From: "Marek Behún" <kabel@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, pali@kernel.org,
"Marek Behún" <kabel@kernel.org>
Subject: [PATCH pci-fixes 1/2] PCI: aardvark: Fix checking for MEM resource type
Date: Thu, 25 Nov 2021 17:01:47 +0100 [thread overview]
Message-ID: <20211125160148.26029-2-kabel@kernel.org> (raw)
In-Reply-To: <20211125160148.26029-1-kabel@kernel.org>
From: Pali Rohár <pali@kernel.org>
IORESOURCE_MEM_64 is not type but type flag. Remove incorrect check for
type IORESOURCE_MEM_64.
Fixes: 64f160e19e92 ("PCI: aardvark: Configure PCIe resources from 'ranges' DT property")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
---
drivers/pci/controller/pci-aardvark.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index c5300d49807a..baa62cdcaab4 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -1544,8 +1544,7 @@ static int advk_pcie_probe(struct platform_device *pdev)
* only PIO for issuing configuration transfers which does
* not use PCIe window configuration.
*/
- if (type != IORESOURCE_MEM && type != IORESOURCE_MEM_64 &&
- type != IORESOURCE_IO)
+ if (type != IORESOURCE_MEM && type != IORESOURCE_IO)
continue;
/*
@@ -1553,8 +1552,7 @@ static int advk_pcie_probe(struct platform_device *pdev)
* configuration is set to transparent memory access so it
* does not need window configuration.
*/
- if ((type == IORESOURCE_MEM || type == IORESOURCE_MEM_64) &&
- entry->offset == 0)
+ if (type == IORESOURCE_MEM && entry->offset == 0)
continue;
/*
--
2.32.0
next prev parent reply other threads:[~2021-11-25 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 16:01 [PATCH pci-fixes 0/2] PCI Aardvark controller fixes Marek Behún
2021-11-25 16:01 ` Marek Behún [this message]
2021-11-25 16:01 ` [PATCH pci-fixes 2/2] Revert "PCI: aardvark: Fix support for PCI_ROM_ADDRESS1 on emulated bridge" Marek Behún
2021-11-30 11:29 ` Lorenzo Pieralisi
2021-12-01 1:53 ` Bjorn Helgaas
2021-12-01 9:50 ` Marek Behún
2021-12-01 12:35 ` Bjorn Helgaas
2021-12-01 17:23 ` Marek Behún
2021-12-01 18:01 ` Bjorn Helgaas
2021-11-30 11:43 ` Pali Rohár
2021-12-02 16:09 ` Bjorn Helgaas
2021-12-06 10:18 ` (subset) [PATCH pci-fixes 0/2] PCI Aardvark controller fixes Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125160148.26029-2-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox