[PATCH v5 08/13] dt-bindings: PCI: Add support for Airoha EN7532

[PATCH v5 08/13] dt-bindings: PCI: Add support for Airoha EN7532

[Felix Fietkau]

From: John Crispin <john@phrozen.org>

EN7532 is an ARM based platform SoC integrating the same PCIe IP as
MT7622, add a binding for it.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: John Crispin <john@phrozen.org>
---
 Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
index 57ae73462272..684227522267 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
@@ -7,6 +7,7 @@ Required properties:
 	"mediatek,mt7622-pcie"
 	"mediatek,mt7623-pcie"
 	"mediatek,mt7629-pcie"
+	"airoha,en7523-pcie"
 - device_type: Must be "pci"
 - reg: Base addresses and lengths of the root ports.
 - reg-names: Names of the above areas to use during resource lookup.
-- 
2.30.1

[PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

[Felix Fietkau]

The EN7523 SoC uses the same controller as MT7622

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
 drivers/pci/controller/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 93b141110537..f1342059c2a3 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP
 
 config PCIE_MEDIATEK
 	tristate "MediaTek PCIe controller"
-	depends on ARCH_MEDIATEK || COMPILE_TEST
+	depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
 	depends on OF
 	depends on PCI_MSI_IRQ_DOMAIN
 	help
-- 
2.30.1

Re: [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

[Bjorn Helgaas]

On Mon, Nov 29, 2021 at 04:33:25PM +0100, Felix Fietkau wrote:
> The EN7523 SoC uses the same controller as MT7622

If you have occasion to post a v6, please:

  - Update the subject line so it starts with a capital letter,
    capitalizes "Airoha" appropriately, and includes "EN7523" as your
    DT patch does, and moves those close to the beginning, e.g.,

      PCI: mediatek: Allow selection for Airoha EN7532

  - Update the commit log so it says what this patch does.  It's OK to
    repeat the subject line.  Add a period at end.

I expected a patch to add "airoha,en7523-pcie" to
drivers/pci/controller/pcie-mediatek.c.  Did I miss it?

Oh, I see your arch/arm/boot/dts/en7523.dtsi has:

  +       pcie0: pcie@1fa91000 {
  +               compatible = "airoha,en7523-pcie", "mediatek,mt7622-pcie";

so I guess you just rely on the existing "mediatek,mt7622-pcie" string
in the driver?

> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/pci/controller/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 93b141110537..f1342059c2a3 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP
>  
>  config PCIE_MEDIATEK
>  	tristate "MediaTek PCIe controller"
> -	depends on ARCH_MEDIATEK || COMPILE_TEST
> +	depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
>  	depends on OF
>  	depends on PCI_MSI_IRQ_DOMAIN
>  	help
> -- 
> 2.30.1
> 

Re: [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

[Bjorn Helgaas]

On Mon, Nov 29, 2021 at 05:55:50PM -0600, Bjorn Helgaas wrote:
> On Mon, Nov 29, 2021 at 04:33:25PM +0100, Felix Fietkau wrote:
> > The EN7523 SoC uses the same controller as MT7622
> 
> If you have occasion to post a v6, please:
> 
>   - Update the subject line so it starts with a capital letter,
>     capitalizes "Airoha" appropriately, and includes "EN7523" as your
>     DT patch does, and moves those close to the beginning, e.g.,
> 
>       PCI: mediatek: Allow selection for Airoha EN7532
> 
>   - Update the commit log so it says what this patch does.  It's OK to
>     repeat the subject line.  Add a period at end.

Sending again since you posted a v6 without doing any of the above.

> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
> > ---
> >  drivers/pci/controller/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 93b141110537..f1342059c2a3 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP
> >  
> >  config PCIE_MEDIATEK
> >  	tristate "MediaTek PCIe controller"
> > -	depends on ARCH_MEDIATEK || COMPILE_TEST
> > +	depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
> >  	depends on OF
> >  	depends on PCI_MSI_IRQ_DOMAIN
> >  	help
> > -- 
> > 2.30.1
> >