* [PATCH v3] PCI: mt7621: Convert driver into 'bool'
@ 2021-12-03 19:24 Sergio Paracuellos
2022-01-05 14:01 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Sergio Paracuellos @ 2021-12-03 19:24 UTC (permalink / raw)
To: linux-pci
Cc: tsbogend, lorenzo.pieralisi, bhelgaas, arnd, linux, linux-kernel
Driver is not ready yet to be compiled as a module since it depends on some
MIPS not exported symbols. We have the following current problems:
Building mips:allmodconfig ... failed
--------------
Error log:
ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
Temporarily move from 'tristate' to 'bool' until a better solution is ready.
Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
simplify condition.
Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes in v3:
- Adjust subject to follow convention:
s/PCI: mt7621: Kconfig:/PCI: mt7621:/
Changes in v2:
- Add Guenter's 'Reviewed-and-tested-by'.
- s/after/until
drivers/pci/controller/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 93b141110537..7fc5135ffbbf 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -332,8 +332,8 @@ config PCIE_APPLE
If unsure, say Y if you have an Apple Silicon system.
config PCIE_MT7621
- tristate "MediaTek MT7621 PCIe Controller"
- depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
+ bool "MediaTek MT7621 PCIe Controller"
+ depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
select PHY_MT7621_PCI
default SOC_MT7621
help
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] PCI: mt7621: Convert driver into 'bool'
2021-12-03 19:24 [PATCH v3] PCI: mt7621: Convert driver into 'bool' Sergio Paracuellos
@ 2022-01-05 14:01 ` Lorenzo Pieralisi
2022-01-05 14:06 ` Sergio Paracuellos
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2022-01-05 14:01 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: linux-pci, tsbogend, bhelgaas, arnd, linux, linux-kernel
On Fri, Dec 03, 2021 at 08:24:54PM +0100, Sergio Paracuellos wrote:
> Driver is not ready yet to be compiled as a module since it depends on some
> MIPS not exported symbols. We have the following current problems:
>
> Building mips:allmodconfig ... failed
> --------------
> Error log:
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
> ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
>
> Temporarily move from 'tristate' to 'bool' until a better solution is ready.
>
> Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
> simplify condition.
>
> Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
> Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes in v3:
> - Adjust subject to follow convention:
> s/PCI: mt7621: Kconfig:/PCI: mt7621:/
> Changes in v2:
> - Add Guenter's 'Reviewed-and-tested-by'.
> - s/after/until
> drivers/pci/controller/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 93b141110537..7fc5135ffbbf 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -332,8 +332,8 @@ config PCIE_APPLE
> If unsure, say Y if you have an Apple Silicon system.
>
> config PCIE_MT7621
> - tristate "MediaTek MT7621 PCIe Controller"
> - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
> + bool "MediaTek MT7621 PCIe Controller"
> + depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
> select PHY_MT7621_PCI
> default SOC_MT7621
> help
> --
> 2.33.0
>
Hi Sergio,
I believe this is still to be pulled in some tree, just asking for
confirmation, please let me know and I will queue it.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] PCI: mt7621: Convert driver into 'bool'
2022-01-05 14:01 ` Lorenzo Pieralisi
@ 2022-01-05 14:06 ` Sergio Paracuellos
0 siblings, 0 replies; 3+ messages in thread
From: Sergio Paracuellos @ 2022-01-05 14:06 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: linux-pci, Thomas Bogendoerfer, Bjorn Helgaas, Arnd Bergmann,
Guenter Roeck, linux-kernel
Hi Lorenzo,
On Wed, Jan 5, 2022 at 3:01 PM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Fri, Dec 03, 2021 at 08:24:54PM +0100, Sergio Paracuellos wrote:
> > Driver is not ready yet to be compiled as a module since it depends on some
> > MIPS not exported symbols. We have the following current problems:
> >
> > Building mips:allmodconfig ... failed
> > --------------
> > Error log:
> > ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
> > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
> >
> > Temporarily move from 'tristate' to 'bool' until a better solution is ready.
> >
> > Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
> > simplify condition.
> >
> > Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
> > Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes in v3:
> > - Adjust subject to follow convention:
> > s/PCI: mt7621: Kconfig:/PCI: mt7621:/
> > Changes in v2:
> > - Add Guenter's 'Reviewed-and-tested-by'.
> > - s/after/until
> > drivers/pci/controller/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 93b141110537..7fc5135ffbbf 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -332,8 +332,8 @@ config PCIE_APPLE
> > If unsure, say Y if you have an Apple Silicon system.
> >
> > config PCIE_MT7621
> > - tristate "MediaTek MT7621 PCIe Controller"
> > - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
> > + bool "MediaTek MT7621 PCIe Controller"
> > + depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
> > select PHY_MT7621_PCI
> > default SOC_MT7621
> > help
> > --
> > 2.33.0
> >
>
> Hi Sergio,
>
> I believe this is still to be pulled in some tree, just asking for
> confirmation, please let me know and I will queue it.
This is already in Linus'tree [0].
>
> Thanks,
> Lorenzo
Best regards,
Sergio Paracuellos
[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pci/controller?id=aa50faff4416c869b52dff68a937c84d29e12f4b
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 19:24 [PATCH v3] PCI: mt7621: Convert driver into 'bool' Sergio Paracuellos
2022-01-05 14:01 ` Lorenzo Pieralisi
2022-01-05 14:06 ` Sergio Paracuellos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox