From: Bjorn Helgaas <helgaas@kernel.org>
To: Ming Wang <wangming01@loongson.cn>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.
Date: Tue, 11 Jan 2022 10:23:46 -0600 [thread overview]
Message-ID: <20220111162346.GA146958@bhelgaas> (raw)
In-Reply-To: <1641632977-6588-1-git-send-email-wangming01@loongson.cn>
On Sat, Jan 08, 2022 at 05:09:37PM +0800, Ming Wang wrote:
> Even so, there is no syntax error. But, this may be a
> clerical error. ';' are more appropriate than ','.
>
> Signed-off-by: Ming Wang <wangming01@loongson.cn>
Applied to pci/misc for v5.17, thanks!
> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 2ed7e3a..8f786a2 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
> goto err_release_irq;
> }
> misc_device->parent = &pdev->dev;
> - misc_device->fops = &pci_endpoint_test_fops,
> + misc_device->fops = &pci_endpoint_test_fops;
>
> err = misc_register(misc_device);
> if (err) {
> --
> 1.8.3.1
>
prev parent reply other threads:[~2022-01-11 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 9:09 [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement Ming Wang
2022-01-11 16:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111162346.GA146958@bhelgaas \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=wangming01@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox