* [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.
@ 2022-01-08 9:09 Ming Wang
2022-01-11 16:23 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Ming Wang @ 2022-01-08 9:09 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Lorenzo Pieralisi,
Krzysztof Wilczyński, Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-pci, linux-kernel
Even so, there is no syntax error. But, this may be a
clerical error. ';' are more appropriate than ','.
Signed-off-by: Ming Wang <wangming01@loongson.cn>
---
drivers/misc/pci_endpoint_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 2ed7e3a..8f786a2 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
goto err_release_irq;
}
misc_device->parent = &pdev->dev;
- misc_device->fops = &pci_endpoint_test_fops,
+ misc_device->fops = &pci_endpoint_test_fops;
err = misc_register(misc_device);
if (err) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.
2022-01-08 9:09 [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement Ming Wang
@ 2022-01-11 16:23 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2022-01-11 16:23 UTC (permalink / raw)
To: Ming Wang
Cc: Kishon Vijay Abraham I, Lorenzo Pieralisi,
Krzysztof Wilczyński, Arnd Bergmann, Greg Kroah-Hartman,
linux-pci, linux-kernel
On Sat, Jan 08, 2022 at 05:09:37PM +0800, Ming Wang wrote:
> Even so, there is no syntax error. But, this may be a
> clerical error. ';' are more appropriate than ','.
>
> Signed-off-by: Ming Wang <wangming01@loongson.cn>
Applied to pci/misc for v5.17, thanks!
> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 2ed7e3a..8f786a2 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
> goto err_release_irq;
> }
> misc_device->parent = &pdev->dev;
> - misc_device->fops = &pci_endpoint_test_fops,
> + misc_device->fops = &pci_endpoint_test_fops;
>
> err = misc_register(misc_device);
> if (err) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-11 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-08 9:09 [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement Ming Wang
2022-01-11 16:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox