From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
"Prasad Malisetty" <pmaliset@codeaurora.org>
Subject: Re: [PATCH 0/3] PCI: qcom: pipe_clk_src fixes for pcie-qcom driver
Date: Fri, 11 Feb 2022 17:57:33 +0000 [thread overview]
Message-ID: <20220211175733.GB2300@lpieralisi> (raw)
In-Reply-To: <CAE-0n52qs0fe2Cz2QChc0RmnddcWtuw-u1Q34=_Q7FVJSw=q2g@mail.gmail.com>
On Thu, Feb 03, 2022 at 09:11:44PM +0000, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2021-12-18 06:02:20)
> > After comparing upstream and downstream Qualcomm PCIe drivers, change
> > the way the driver works with the pipe_clk_src multiplexing.
> >
> > The clock should be switched to using ref_clk (TCXO) as a parent before
> > turning the PCIE_x_GDSC power domain off and can be switched to using
> > PHY's pipe_clk after this power domain is turned on.
> >
> > Downstream driver uses regulators for the GDSC, so current approach also
> > (incorrectly) uses them. However upstream driver uses power-domain and
> > so GDSC is maintained using pm_runtime_foo() calls. Change order of
> > operations to implement these requirements.
>
> Prasad, can you test/review this series?
Waiting for testing/review and Bjorn/Andy ACKs.
Lorenzo
prev parent reply other threads:[~2022-02-11 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 14:02 [PATCH 0/3] PCI: qcom: pipe_clk_src fixes for pcie-qcom driver Dmitry Baryshkov
2021-12-18 14:02 ` [PATCH 1/3] PCI: qcom: Balance pm_runtime_foo() calls Dmitry Baryshkov
2021-12-18 14:02 ` [PATCH 2/3] PCI: qcom: Fix pipe_clk_src reparenting Dmitry Baryshkov
2022-02-04 4:03 ` Bjorn Andersson
2022-02-04 8:36 ` Dmitry Baryshkov
2021-12-18 14:02 ` [PATCH 3/3] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-02-02 4:37 ` [PATCH 0/3] PCI: qcom: pipe_clk_src fixes for pcie-qcom driver Vinod Koul
2022-02-03 21:11 ` Stephen Boyd
2022-02-11 17:57 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211175733.GB2300@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pmaliset@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox