From: Bjorn Helgaas <helgaas@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: linux-pci@vger.kernel.org, kishon@ti.com,
lorenzo.pieralisi@arm.com, kw@linux.com, jingoohan1@gmail.com,
gustavo.pimentel@synopsys.com, lznuaa@gmail.com,
hongxing.zhu@nxp.com
Subject: Re: [RFC PATCH 1/4] PCI: designware-ep: Allow pcie_ep_set_bar change inbound map address
Date: Thu, 17 Feb 2022 15:53:58 -0600 [thread overview]
Message-ID: <20220217215358.GA308489@bhelgaas> (raw)
In-Reply-To: <20220215053844.7119-2-Frank.Li@nxp.com>
In the subject, "pcie_ep_set_bar" looks like *part* of a function
name. Please include the entire function name and add "()" after it.
On Mon, Feb 14, 2022 at 11:38:41PM -0600, Frank Li wrote:
> ntb_transfer will set memory map windows after probe.
> So the inbound map address need be updated dynamtically.
I don't see "ntb_transfer" in the tree. If it's a function, please
add "()" after the name. Otherwise, please say more about what
"ntb_transfer" is.
s/dynamtically/dynamically/
Please make the commit log say what the patch *does*, not just what
needs to happen.
Bjorn
next prev parent reply other threads:[~2022-02-17 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 5:38 [RFC PATCH 0/4] NTB function for PCIe RC to EP connection Frank Li
2022-02-15 5:38 ` [RFC PATCH 1/4] PCI: designware-ep: Allow pcie_ep_set_bar change inbound map address Frank Li
2022-02-17 21:53 ` Bjorn Helgaas [this message]
2022-02-17 22:13 ` Zhi Li
2022-02-15 5:38 ` [RFC PATCH 2/4] NTB: epf: Added more flexible memory map method Frank Li
2022-02-17 21:59 ` Bjorn Helgaas
2022-02-17 22:24 ` Zhi Li
2022-02-17 22:43 ` Bjorn Helgaas
2022-02-15 5:38 ` [RFC PATCH 3/4] NTB: EPF: support NTB transfer between PCI RC and EP connection Frank Li
2022-02-17 22:38 ` Bjorn Helgaas
2022-02-17 22:59 ` Zhi Li
2022-02-15 5:38 ` [RFC PATCH 4/4] Documentation: PCI: Add specification for the PCI vNTB function device Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217215358.GA308489@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lznuaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox