Re: [RFC PATCH 2/4] NTB: epf: Added more flexible memory map method

[Bjorn Helgaas <helgaas@kernel.org>]

On Thu, Feb 17, 2022 at 04:24:56PM -0600, Zhi Li wrote:
> On Thu, Feb 17, 2022 at 3:59 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > [+cc Jon, Dave, Allen, linux-ntb, since you need at least an ack from
> > the NTB folks; beginning of thread:
> > https://lore.kernel.org/r/20220215053844.7119-1-Frank.Li@nxp.com]
> >
> > In subject, s/Added/Add/.
> >
> > But I don't think it's quite right yet, because this doesn't actually add
> > any functions.
> 
> How about "Allow more flexibility in the memory bar map method"?

s/bar/BAR/

Are you saying that the BAR numbers were fixed before, and you're
adding the ability to change the BAR numbers?  It would be useful to
know what sort of flexibility you're adding.

> > On Mon, Feb 14, 2022 at 11:38:42PM -0600, Frank Li wrote:
> > > Supported below memory map method
> > >
> > > bar 0: config and spad data
> > > bar 2: door bell
> > > bar 4: memory map windows
> >
> > s/bar/BAR/
> > s/spad/?/ (I don't know what this is)
> 
> SCRATCHPAD REGION
> https://www.kernel.org/doc/html/latest/driver-api/ntb.html

Just spelling out "scrachpad" is probably enough.

And s/door bell/doorbell/ to match your usage elsewhere.

> > Please make the commit log say what this patch does.
> 
> Does it help if attach ASCII diagram in patch 3/4 or cover letter one

The diagram is nice, but doesn't need to be replicated everywhere.  A
description of what the patch does would be better.

Bjorn