* Re: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU [not found] <20220714185700.6137-1-pali@kernel.org> @ 2022-07-14 20:04 ` Bjorn Helgaas 2022-07-15 8:04 ` Pali Rohár 0 siblings, 1 reply; 3+ messages in thread From: Bjorn Helgaas @ 2022-07-14 20:04 UTC (permalink / raw) To: Pali Rohár Cc: kernel test robot, kbuild-all, Lorenzo Pieralisi, Bjorn Helgaas, Russell King, linux-arm-kernel, linux-kernel, linux-pci [+cc linux-pci, update Lorenzo's email addr] Hi Pali, Thanks for cc'ing me. I think your previous notes didn't include linux-pci or me, so I missed them. It looks like bc02973a06a6 was merged via the PCI tree for v5.17 [1], so we should probably merge the fix the same way. Russell, let me know if you object. Otherwise, I put it on pci/misc for v5.20. [1] https://lore.kernel.org/r/20220114155608.GA557997@bhelgaas On Thu, Jul 14, 2022 at 08:57:00PM +0200, Pali Rohár wrote: > Custom ARM version of pci_remap_iospace() is implemented only for MMU > kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU. > > See compilation failures: > https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/ > https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/ > https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/ > https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/ > > Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Pali Rohár <pali@kernel.org> > > --- > > PING!!!! Is somebody interested in fixing these compile errors? As nobody > answered to my emails where I proposed this fix more than half year ago and > asked for opinion... > > https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/ > https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ > https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/ > https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/ > https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/ > > If nobody is interested then please STOP sending me these Intel "0-DAY CI > Kernel Test Service" emails. Thanks! > --- > arch/arm/include/asm/io.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index eba7cbc93b86..47cf79229b7c 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h > @@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type); > static inline void pci_ioremap_set_mem_type(int mem_type) {} > #endif > > +#ifdef CONFIG_MMU > struct resource; > > #define pci_remap_iospace pci_remap_iospace > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr); > +#endif > > /* > * PCI configuration space mapping function. > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU 2022-07-14 20:04 ` [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU Bjorn Helgaas @ 2022-07-15 8:04 ` Pali Rohár 2022-07-15 16:39 ` Bjorn Helgaas 0 siblings, 1 reply; 3+ messages in thread From: Pali Rohár @ 2022-07-15 8:04 UTC (permalink / raw) To: Bjorn Helgaas Cc: kernel test robot, kbuild-all, Lorenzo Pieralisi, Bjorn Helgaas, Russell King, linux-arm-kernel, linux-kernel, linux-pci On Thursday 14 July 2022 15:04:43 Bjorn Helgaas wrote: > [+cc linux-pci, update Lorenzo's email addr] > > Hi Pali, > > Thanks for cc'ing me. I think your previous notes didn't include > linux-pci or me, so I missed them. https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ > It looks like bc02973a06a6 was merged via the PCI tree for v5.17 [1], > so we should probably merge the fix the same way. > > Russell, let me know if you object. Otherwise, I put it on pci/misc > for v5.20. > > [1] https://lore.kernel.org/r/20220114155608.GA557997@bhelgaas > > On Thu, Jul 14, 2022 at 08:57:00PM +0200, Pali Rohár wrote: > > Custom ARM version of pci_remap_iospace() is implemented only for MMU > > kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU. > > > > See compilation failures: > > https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/ > > https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/ > > https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/ > > https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/ > > > > Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > > --- > > > > PING!!!! Is somebody interested in fixing these compile errors? As nobody > > answered to my emails where I proposed this fix more than half year ago and > > asked for opinion... > > > > https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/ > > https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ > > https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/ > > https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/ > > https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/ > > > > If nobody is interested then please STOP sending me these Intel "0-DAY CI > > Kernel Test Service" emails. Thanks! > > --- > > arch/arm/include/asm/io.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > > index eba7cbc93b86..47cf79229b7c 100644 > > --- a/arch/arm/include/asm/io.h > > +++ b/arch/arm/include/asm/io.h > > @@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type); > > static inline void pci_ioremap_set_mem_type(int mem_type) {} > > #endif > > > > +#ifdef CONFIG_MMU > > struct resource; > > > > #define pci_remap_iospace pci_remap_iospace > > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr); > > +#endif > > > > /* > > * PCI configuration space mapping function. > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU 2022-07-15 8:04 ` Pali Rohár @ 2022-07-15 16:39 ` Bjorn Helgaas 0 siblings, 0 replies; 3+ messages in thread From: Bjorn Helgaas @ 2022-07-15 16:39 UTC (permalink / raw) To: Pali Rohár Cc: kernel test robot, kbuild-all, Lorenzo Pieralisi, Bjorn Helgaas, Russell King, linux-arm-kernel, linux-kernel, linux-pci On Fri, Jul 15, 2022 at 10:04:12AM +0200, Pali Rohár wrote: > On Thursday 14 July 2022 15:04:43 Bjorn Helgaas wrote: > > [+cc linux-pci, update Lorenzo's email addr] > > > > Hi Pali, > > > > Thanks for cc'ing me. I think your previous notes didn't include > > linux-pci or me, so I missed them. > > https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ Sorry I missed it! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-15 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220714185700.6137-1-pali@kernel.org>
2022-07-14 20:04 ` [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU Bjorn Helgaas
2022-07-15 8:04 ` Pali Rohár
2022-07-15 16:39 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox