From: "Longpeng(Mike)" <longpeng2@huawei.com>
To: <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jianjay.zhou@huawei.com>, <zhuangshengen@huawei.com>,
<arei.gonglei@huawei.com>, <yechuan@huawei.com>,
<huangzhichao@huawei.com>, <xiehong@huawei.com>,
Longpeng <longpeng2@huawei.com>
Subject: [RFC 1/4] pci/sriov: extract sriov_numvfs common helper
Date: Fri, 11 Nov 2022 22:27:19 +0800 [thread overview]
Message-ID: <20221111142722.1172-2-longpeng2@huawei.com> (raw)
In-Reply-To: <20221111142722.1172-1-longpeng2@huawei.com>
From: Longpeng <longpeng2@huawei.com>
Extract a common helper to set sriov nums.
Signed-off-by: Longpeng <longpeng2@huawei.com>
---
drivers/pci/iov.c | 38 +++++++++++++++++++++++---------------
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 952217572113..3b441cd92960 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -406,23 +406,9 @@ static ssize_t sriov_numvfs_show(struct device *dev,
return sysfs_emit(buf, "%u\n", num_vfs);
}
-/*
- * num_vfs > 0; number of VFs to enable
- * num_vfs = 0; disable all VFs
- *
- * Note: SRIOV spec does not allow partial VF
- * disable, so it's all or none.
- */
-static ssize_t sriov_numvfs_store(struct device *dev,
- struct device_attribute *attr,
- const char *buf, size_t count)
+static int sriov_numvfs_common(struct pci_dev *pdev, u16 num_vfs)
{
- struct pci_dev *pdev = to_pci_dev(dev);
int ret = 0;
- u16 num_vfs;
-
- if (kstrtou16(buf, 0, &num_vfs) < 0)
- return -EINVAL;
if (num_vfs > pci_sriov_get_totalvfs(pdev))
return -ERANGE;
@@ -471,6 +457,28 @@ static ssize_t sriov_numvfs_store(struct device *dev,
exit:
device_unlock(&pdev->dev);
+ return ret;
+}
+
+/*
+ * num_vfs > 0; number of VFs to enable
+ * num_vfs = 0; disable all VFs
+ *
+ * Note: SRIOV spec does not allow partial VF
+ * disable, so it's all or none.
+ */
+static ssize_t sriov_numvfs_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct pci_dev *pdev = to_pci_dev(dev);
+ int ret;
+ u16 num_vfs;
+
+ if (kstrtou16(buf, 0, &num_vfs) < 0)
+ return -EINVAL;
+
+ ret = sriov_numvfs_common(pdev, num_vfs);
if (ret < 0)
return ret;
--
2.23.0
next prev parent reply other threads:[~2022-11-11 14:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 14:27 [RFC 0/4] pci/sriov: support VFs dynamic addition Longpeng(Mike)
2022-11-11 14:27 ` Longpeng(Mike) [this message]
2022-11-11 14:27 ` [RFC 2/4] pci/sriov: add vf_bitmap to mark the vf id allocation Longpeng(Mike)
2022-11-11 14:27 ` [RFC 3/4] pci/sriov: add sriov_numfs_no_scan interface Longpeng(Mike)
2022-11-11 14:27 ` [RFC 4/4] pci/sriov: add sriov_scan_vf_id interface Longpeng(Mike)
2022-11-11 16:39 ` [RFC 0/4] pci/sriov: support VFs dynamic addition Leon Romanovsky
2022-11-13 13:47 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 7:04 ` Leon Romanovsky
2022-11-14 12:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 13:09 ` Leon Romanovsky
2022-11-14 14:06 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 14:20 ` Leon Romanovsky
2022-11-15 1:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 1:50 ` Oliver O'Halloran
2022-11-15 8:32 ` Leon Romanovsky
2022-11-15 9:36 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 10:02 ` Leon Romanovsky
2022-11-15 10:27 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 12:49 ` Oliver O'Halloran
2022-11-15 2:06 ` Oliver O'Halloran
2022-11-16 0:52 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-11 23:07 ` Bjorn Helgaas
2022-11-13 13:49 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111142722.1172-2-longpeng2@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=bhelgaas@google.com \
--cc=huangzhichao@huawei.com \
--cc=jianjay.zhou@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xiehong@huawei.com \
--cc=yechuan@huawei.com \
--cc=zhuangshengen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox