From: "Longpeng(Mike)" <longpeng2@huawei.com>
To: <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jianjay.zhou@huawei.com>, <zhuangshengen@huawei.com>,
<arei.gonglei@huawei.com>, <yechuan@huawei.com>,
<huangzhichao@huawei.com>, <xiehong@huawei.com>,
Longpeng <longpeng2@huawei.com>
Subject: [RFC 2/4] pci/sriov: add vf_bitmap to mark the vf id allocation
Date: Fri, 11 Nov 2022 22:27:20 +0800 [thread overview]
Message-ID: <20221111142722.1172-3-longpeng2@huawei.com> (raw)
In-Reply-To: <20221111142722.1172-1-longpeng2@huawei.com>
From: Longpeng <longpeng2@huawei.com>
Add a bitmap to mark the vf id allocation, the can be use to
avoid the repeated allocations.
Signed-off-by: Longpeng <longpeng2@huawei.com>
---
drivers/pci/iov.c | 13 +++++++++++++
drivers/pci/pci.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 3b441cd92960..886489aae0de 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -341,6 +341,8 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)
pci_bus_add_device(virtfn);
+ __set_bit(id, iov->vf_bitmap);
+
return 0;
failed1:
@@ -357,6 +359,7 @@ void pci_iov_remove_virtfn(struct pci_dev *dev, int id)
{
char buf[VIRTFN_ID_LEN];
struct pci_dev *virtfn;
+ struct pci_sriov *iov;
virtfn = pci_get_domain_bus_and_slot(pci_domain_nr(dev->bus),
pci_iov_virtfn_bus(dev, id),
@@ -364,6 +367,9 @@ void pci_iov_remove_virtfn(struct pci_dev *dev, int id)
if (!virtfn)
return;
+ iov = pci_physfn(dev)->sriov;
+ __clear_bit(id, iov->vf_bitmap);
+
sprintf(buf, "virtfn%u", id);
sysfs_remove_link(&dev->dev.kobj, buf);
/*
@@ -791,6 +797,11 @@ static int sriov_init(struct pci_dev *dev, int pos)
if (!iov)
return -ENOMEM;
+ rc = -ENOMEM;
+ iov->vf_bitmap = bitmap_zalloc(total, GFP_KERNEL);
+ if (!iov->vf_bitmap)
+ goto free_iov;
+
nres = 0;
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
res = &dev->resource[i + PCI_IOV_RESOURCES];
@@ -853,6 +864,7 @@ static int sriov_init(struct pci_dev *dev, int pos)
res->flags = 0;
}
+free_iov:
kfree(iov);
return rc;
}
@@ -864,6 +876,7 @@ static void sriov_release(struct pci_dev *dev)
if (dev != dev->sriov->dev)
pci_dev_put(dev->sriov->dev);
+ bitmap_free(dev->sriov->vf_bitmap);
kfree(dev->sriov);
dev->sriov = NULL;
}
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index b1ebb7ab8805..a76d4ff83886 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -301,6 +301,7 @@ struct pci_sriov {
u16 subsystem_device; /* VF subsystem device */
resource_size_t barsz[PCI_SRIOV_NUM_BARS]; /* VF BAR size */
bool drivers_autoprobe; /* Auto probing of VFs by driver */
+ unsigned long *vf_bitmap; /* Allocated VFs */
};
/**
--
2.23.0
next prev parent reply other threads:[~2022-11-11 14:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 14:27 [RFC 0/4] pci/sriov: support VFs dynamic addition Longpeng(Mike)
2022-11-11 14:27 ` [RFC 1/4] pci/sriov: extract sriov_numvfs common helper Longpeng(Mike)
2022-11-11 14:27 ` Longpeng(Mike) [this message]
2022-11-11 14:27 ` [RFC 3/4] pci/sriov: add sriov_numfs_no_scan interface Longpeng(Mike)
2022-11-11 14:27 ` [RFC 4/4] pci/sriov: add sriov_scan_vf_id interface Longpeng(Mike)
2022-11-11 16:39 ` [RFC 0/4] pci/sriov: support VFs dynamic addition Leon Romanovsky
2022-11-13 13:47 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 7:04 ` Leon Romanovsky
2022-11-14 12:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 13:09 ` Leon Romanovsky
2022-11-14 14:06 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-14 14:20 ` Leon Romanovsky
2022-11-15 1:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 1:50 ` Oliver O'Halloran
2022-11-15 8:32 ` Leon Romanovsky
2022-11-15 9:36 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 10:02 ` Leon Romanovsky
2022-11-15 10:27 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-15 12:49 ` Oliver O'Halloran
2022-11-15 2:06 ` Oliver O'Halloran
2022-11-16 0:52 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-11-11 23:07 ` Bjorn Helgaas
2022-11-13 13:49 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111142722.1172-3-longpeng2@huawei.com \
--to=longpeng2@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=bhelgaas@google.com \
--cc=huangzhichao@huawei.com \
--cc=jianjay.zhou@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xiehong@huawei.com \
--cc=yechuan@huawei.com \
--cc=zhuangshengen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox