From: Bjorn Helgaas <helgaas@kernel.org>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Date: Tue, 28 Mar 2023 12:34:48 -0500 [thread overview]
Message-ID: <20230328173448.GA2952425@bhelgaas> (raw)
In-Reply-To: <20230328110610.3824-1-cai.huoqing@linux.dev>
On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
> Remove pci_p2pmem_dma() reference,
> because pci_p2pmem_dma() method is already removed.
AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo,
and pci_p2pdma_distance_many() was intended?
I'm happy to either merge this patch (with an updated commit log) to
remove the comment text or merge a patch correct the comment text.
I just don't want to merge this with a commit log that says we removed
the pci_p2pmem_dma() method when it never actually existed.
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> v1->v2:
> 1.remove pci_p2pmem_dma() reference directly instead of
> using pci_p2pdma_map_segment().
>
> v1 link:
> https://lore.kernel.org/lkml/eea970cd-d781-9d4c-e020-9086505a4ba7@deltatee.com/
>
> drivers/pci/p2pdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..6cd98ffca198 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>
> /**
> * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> - * the specified list of clients and shortest distance (as determined
> - * by pci_p2pmem_dma())
> + * the specified list of clients and shortest distance
> * @clients: array of devices to check (NULL-terminated)
> * @num_clients: number of client devices in the list
> *
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-28 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:06 [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many() Cai Huoqing
2023-03-28 15:41 ` Logan Gunthorpe
2023-03-28 17:34 ` Bjorn Helgaas [this message]
2023-03-28 17:36 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328173448.GA2952425@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox