From: Logan Gunthorpe <logang@deltatee.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Cai Huoqing <cai.huoqing@linux.dev>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Date: Tue, 28 Mar 2023 11:36:14 -0600 [thread overview]
Message-ID: <5017f565-1047-6f0c-e578-e8ed9d31802f@deltatee.com> (raw)
In-Reply-To: <20230328173448.GA2952425@bhelgaas>
On 2023-03-28 11:34, Bjorn Helgaas wrote:
> On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
>> Remove pci_p2pmem_dma() reference,
>> because pci_p2pmem_dma() method is already removed.
>
> AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo,
> and pci_p2pdma_distance_many() was intended?
>
> I'm happy to either merge this patch (with an updated commit log) to
> remove the comment text or merge a patch correct the comment text.
>
> I just don't want to merge this with a commit log that says we removed
> the pci_p2pmem_dma() method when it never actually existed.
Ah, yes that's fair. I thought pci_p2pmem_dma() was an odd function
name. Good to confirm it never existed.
Thanks,
Logan
prev parent reply other threads:[~2023-03-28 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:06 [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many() Cai Huoqing
2023-03-28 15:41 ` Logan Gunthorpe
2023-03-28 17:34 ` Bjorn Helgaas
2023-03-28 17:36 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017f565-1047-6f0c-e578-e8ed9d31802f@deltatee.com \
--to=logang@deltatee.com \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox