Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jim Quinlan <james.quinlan@broadcom.com>
To: linux-pci@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Cyril Brulebois <kibi@debian.org>,
	Phil Elwell <phil@raspberrypi.com>,
	bcm-kernel-feedback-list@broadcom.com,
	james.quinlan@broadcom.com
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
	"Jim Quinlan" <jim2101024@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v6 4/5] PCI: brcmstb: Assert PERST# on BCM2711
Date: Fri, 23 Jun 2023 10:40:57 -0400	[thread overview]
Message-ID: <20230623144100.34196-5-james.quinlan@broadcom.com> (raw)
In-Reply-To: <20230623144100.34196-1-james.quinlan@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

The current PCIe driver assumes PERST# is asserted when probe() is invoked.
Some older versions of the 2711/RPi bootloader left PERST# unasserted, as
the Raspian OS does assert PERST# on probe().  For this reason, we assert
PERST# for BCM2711 SOCs (i.e. RPi).

Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index fe0415a98c63..7b698a9a851e 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -884,6 +884,11 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
 
 	/* Reset the bridge */
 	pcie->bridge_sw_init_set(pcie, 1);
+
+	/* Ensure that PERST# is asserted; some bootloaders may deassert it. */
+	if (pcie->type == BCM2711)
+		pcie->perst_set(pcie, 1);
+
 	usleep_range(100, 200);
 
 	/* Take the bridge out of reset */
-- 
2.17.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

  parent reply	other threads:[~2023-06-23 14:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 14:40 [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Jim Quinlan
2023-08-21 14:46   ` Lorenzo Pieralisi
2023-08-21 15:25     ` Jim Quinlan
2023-08-21 15:41       ` Lorenzo Pieralisi
2023-08-21 16:01         ` Jim Quinlan
2023-08-23  7:30           ` Lorenzo Pieralisi
2023-08-23 12:42             ` Bjorn Helgaas
2023-08-23 15:02               ` Jim Quinlan
2023-08-23 14:48             ` Rob Herring
2023-08-23 16:29               ` Lorenzo Pieralisi
2023-08-23 18:26                 ` Manivannan Sadhasivam
2023-08-24 15:19                   ` Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 2/5] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device Jim Quinlan
2023-09-05 20:24   ` Sam Edwards
2023-06-23 14:40 ` [PATCH v6 3/5] PCI: brcmstb: Set higher value for internal bus timeout Jim Quinlan
2023-07-28  8:43   ` Lorenzo Pieralisi
     [not found]     ` <CA+-6iNzuNZ0TGUvSKsq3outKnCBTkqtxygKOuM4=J-CPxcBb2g@mail.gmail.com>
2023-08-14 19:30       ` Jim Quinlan
2023-08-14 22:06         ` Bjorn Helgaas
2023-08-15 12:34           ` Jim Quinlan
2023-06-23 14:40 ` Jim Quinlan [this message]
2023-06-23 14:40 ` [PATCH v6 5/5] PCI: brcmstb: Remove stale comment Jim Quinlan
2023-06-29  1:59 ` [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Cyril Brulebois
2023-08-21  8:34 ` Lorenzo Pieralisi
2023-08-21 12:15   ` Jim Quinlan
2023-08-21 14:42     ` Lorenzo Pieralisi
2023-08-24 15:36 ` (subset) " Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623144100.34196-5-james.quinlan@broadcom.com \
    --to=james.quinlan@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jim2101024@gmail.com \
    --cc=kibi@debian.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox