From: Sam Edwards <cfsworks@gmail.com>
To: Jim Quinlan <james.quinlan@broadcom.com>,
linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Cyril Brulebois <kibi@debian.org>,
Phil Elwell <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Jim Quinlan" <jim2101024@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/5] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device
Date: Tue, 5 Sep 2023 14:24:50 -0600 [thread overview]
Message-ID: <74c93380-2f2a-f42d-027a-8c827e794812@gmail.com> (raw)
In-Reply-To: <20230623144100.34196-3-james.quinlan@broadcom.com>
On 6/23/23 08:40, Jim Quinlan wrote:
Hi Jim,
As I understand, the issue that this patch fixes can be difficult to
trigger reliably. So I'll report that the abort occurs 100% of the time
on a Compute Module 4, installed in slot 3 of a Turing Pi 2 cluster
board, when a bootloader (U-Boot, in my case) is in the boot path. The
third slot of the TP2 board connects to an ASM1061 chip with the CLKREQ#
line left floating. I do not know why the bootloader is necessary for
the crash to occur; I suspect it's timing-related.
With this patch applied to my kernel, my observed crash rate goes from
100% to 0%, so:
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Tested-by: Cyril Brulebois <cyril@debamax.com>
Tested-by: Sam Edwards <CFSworks@gmail.com>
Many thanks,
Sam
next prev parent reply other threads:[~2023-09-05 20:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 14:40 [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Jim Quinlan
2023-08-21 14:46 ` Lorenzo Pieralisi
2023-08-21 15:25 ` Jim Quinlan
2023-08-21 15:41 ` Lorenzo Pieralisi
2023-08-21 16:01 ` Jim Quinlan
2023-08-23 7:30 ` Lorenzo Pieralisi
2023-08-23 12:42 ` Bjorn Helgaas
2023-08-23 15:02 ` Jim Quinlan
2023-08-23 14:48 ` Rob Herring
2023-08-23 16:29 ` Lorenzo Pieralisi
2023-08-23 18:26 ` Manivannan Sadhasivam
2023-08-24 15:19 ` Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 2/5] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device Jim Quinlan
2023-09-05 20:24 ` Sam Edwards [this message]
2023-06-23 14:40 ` [PATCH v6 3/5] PCI: brcmstb: Set higher value for internal bus timeout Jim Quinlan
2023-07-28 8:43 ` Lorenzo Pieralisi
[not found] ` <CA+-6iNzuNZ0TGUvSKsq3outKnCBTkqtxygKOuM4=J-CPxcBb2g@mail.gmail.com>
2023-08-14 19:30 ` Jim Quinlan
2023-08-14 22:06 ` Bjorn Helgaas
2023-08-15 12:34 ` Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 4/5] PCI: brcmstb: Assert PERST# on BCM2711 Jim Quinlan
2023-06-23 14:40 ` [PATCH v6 5/5] PCI: brcmstb: Remove stale comment Jim Quinlan
2023-06-29 1:59 ` [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Cyril Brulebois
2023-08-21 8:34 ` Lorenzo Pieralisi
2023-08-21 12:15 ` Jim Quinlan
2023-08-21 14:42 ` Lorenzo Pieralisi
2023-08-24 15:36 ` (subset) " Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c93380-2f2a-f42d-027a-8c827e794812@gmail.com \
--to=cfsworks@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kibi@debian.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox