From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: mani@kernel.org, lpieralisi@kernel.org, kishon@kernel.org,
bhelgaas@google.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] PCI: endpoint: Remove redundant dev_err().
Date: Mon, 26 Jun 2023 03:34:53 +0900 [thread overview]
Message-ID: <20230625183453.GB2459283@rocinante> (raw)
In-Reply-To: <20230607093514.104012-1-yang.lee@linux.alibaba.com>
Hello,
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
This extra dev_err() appears to have since been removed, per:
https://git.kernel.org/pci/pci/c/1bf5f25324f7
Nevertheless, thank you for sending the patch over!
Krzysztof
prev parent reply other threads:[~2023-06-25 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 9:35 [PATCH -next] PCI: endpoint: Remove redundant dev_err() Yang Li
2023-06-07 20:19 ` kernel test robot
2023-06-25 18:34 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625183453.GB2459283@rocinante \
--to=kw@linux.com \
--cc=abaci@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox