From: kernel test robot <lkp@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>, mani@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, lpieralisi@kernel.org,
kw@linux.com, kishon@kernel.org, bhelgaas@google.com,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] PCI: endpoint: Remove redundant dev_err().
Date: Thu, 8 Jun 2023 04:19:52 +0800 [thread overview]
Message-ID: <202306080418.i64hTj5T-lkp@intel.com> (raw)
In-Reply-To: <20230607093514.104012-1-yang.lee@linux.alibaba.com>
Hi Yang,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20230607]
url: https://github.com/intel-lab-lkp/linux/commits/Yang-Li/PCI-endpoint-Remove-redundant-dev_err/20230607-173708
base: next-20230607
patch link: https://lore.kernel.org/r/20230607093514.104012-1-yang.lee%40linux.alibaba.com
patch subject: [PATCH -next] PCI: endpoint: Remove redundant dev_err().
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230608/202306080418.i64hTj5T-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
git checkout next-20230607
b4 shazam https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@linux.alibaba.com
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pci/endpoint/functions/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306080418.i64hTj5T-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pci/endpoint/functions/pci-epf-mhi.c: In function 'pci_epf_mhi_bind':
>> drivers/pci/endpoint/functions/pci-epf-mhi.c:347:24: warning: unused variable 'dev' [-Wunused-variable]
347 | struct device *dev = &epf->dev;
| ^~~
vim +/dev +347 drivers/pci/endpoint/functions/pci-epf-mhi.c
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 341
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 342 static int pci_epf_mhi_bind(struct pci_epf *epf)
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 343 {
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 344 struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 345 struct pci_epc *epc = epf->epc;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 346 struct platform_device *pdev = to_platform_device(epc->dev.parent);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 @347 struct device *dev = &epf->dev;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 348 struct resource *res;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 349 int ret;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 350
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 351 /* Get MMIO base address from Endpoint controller */
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 352 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mmio");
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 353 epf_mhi->mmio_phys = res->start;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 354 epf_mhi->mmio_size = resource_size(res);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 355
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 356 epf_mhi->mmio = ioremap(epf_mhi->mmio_phys, epf_mhi->mmio_size);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 357 if (IS_ERR(epf_mhi->mmio))
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 358 return PTR_ERR(epf_mhi->mmio);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 359
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 360 ret = platform_get_irq_byname(pdev, "doorbell");
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 361 if (ret < 0) {
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 362 iounmap(epf_mhi->mmio);
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 363 return ret;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 364 }
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 365
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 366 epf_mhi->irq = ret;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 367
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 368 return 0;
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 369 }
7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 370
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-06-07 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 9:35 [PATCH -next] PCI: endpoint: Remove redundant dev_err() Yang Li
2023-06-07 20:19 ` kernel test robot [this message]
2023-06-25 18:34 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306080418.i64hTj5T-lkp@intel.com \
--to=lkp@intel.com \
--cc=abaci@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox