Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Cc: linux-kernel@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH 0/2] PCI/DPC: Improve register field accessing
Date: Fri, 13 Oct 2023 14:20:02 +0300	[thread overview]
Message-ID: <20231013112004.4239-1-ilpo.jarvinen@linux.intel.com> (raw)

This an alternative approach to the patch in:
  https://lore.kernel.org/linux-pci/20231010204436.1000644-7-helgaas@kernel.org/

It adds names to all the reason literals too (which makes it incompatible
with FIELD_GET() for the reason and ext_reason). When the reasons are
named instead of literals, it's very easy to understand the code just by
reading it (no need to lookup the meaning of those numbers from spec or
otherwise).

Also 0xfff4 the other patch missed is converted here.

Just let me know if I should, for example, base the additional changes
on top of that other change.

Ilpo Järvinen (2):
  PCI: Add PCI_EXP_DPC_* field details
  PCI/DPC: Use defines with register fields

 drivers/pci/pcie/dpc.c        | 39 +++++++++++++++++++++--------------
 include/uapi/linux/pci_regs.h |  7 +++++++
 2 files changed, 31 insertions(+), 15 deletions(-)

-- 
2.30.2


             reply	other threads:[~2023-10-13 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 11:20 Ilpo Järvinen [this message]
2023-10-13 11:20 ` [PATCH 1/2] PCI: Add PCI_EXP_DPC_* field details Ilpo Järvinen
2023-10-13 11:20 ` [PATCH 2/2] PCI/DPC: Use defines with register fields Ilpo Järvinen
2023-10-13 20:19   ` Bjorn Helgaas
2023-10-16 12:53     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231013112004.4239-1-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox