* [PATCH] p2pdma: remove redundant goto
@ 2023-10-23 8:40 Tadeusz Struk
2023-10-23 15:51 ` Logan Gunthorpe
2023-10-23 17:19 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Tadeusz Struk @ 2023-10-23 8:40 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Logan Gunthorpe, linux-pci, Tadeusz Struk, Tadeusz Struk
Remove redundant goto in pci_alloc_p2pmem()
Signed-off-by: Tadeusz Struk <tstruk@gmail.com>
---
drivers/pci/p2pdma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index fa7370f9561a..a7776315996c 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size)
if (unlikely(!percpu_ref_tryget_live_rcu(ref))) {
gen_pool_free(p2pdma->pool, (unsigned long) ret, size);
ret = NULL;
- goto out;
}
out:
rcu_read_unlock();
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] p2pdma: remove redundant goto
2023-10-23 8:40 [PATCH] p2pdma: remove redundant goto Tadeusz Struk
@ 2023-10-23 15:51 ` Logan Gunthorpe
2023-10-23 17:19 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Logan Gunthorpe @ 2023-10-23 15:51 UTC (permalink / raw)
To: Tadeusz Struk, Bjorn Helgaas; +Cc: linux-pci, Tadeusz Struk
On 2023-10-23 02:40, Tadeusz Struk wrote:
> Remove redundant goto in pci_alloc_p2pmem()
>
> Signed-off-by: Tadeusz Struk <tstruk@gmail.com>
Makes sense to me.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Logan
> ---
> drivers/pci/p2pdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index fa7370f9561a..a7776315996c 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size)
> if (unlikely(!percpu_ref_tryget_live_rcu(ref))) {
> gen_pool_free(p2pdma->pool, (unsigned long) ret, size);
> ret = NULL;
> - goto out;
> }
> out:
> rcu_read_unlock();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] p2pdma: remove redundant goto
2023-10-23 8:40 [PATCH] p2pdma: remove redundant goto Tadeusz Struk
2023-10-23 15:51 ` Logan Gunthorpe
@ 2023-10-23 17:19 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2023-10-23 17:19 UTC (permalink / raw)
To: Tadeusz Struk; +Cc: Bjorn Helgaas, Logan Gunthorpe, linux-pci, Tadeusz Struk
On Mon, Oct 23, 2023 at 10:40:50AM +0200, Tadeusz Struk wrote:
> Remove redundant goto in pci_alloc_p2pmem()
>
> Signed-off-by: Tadeusz Struk <tstruk@gmail.com>
Thanks, applied to pci/p2pdma with Logan's reviewed-by for v6.7.
Updated the subject line to:
PCI/P2PDMA: Remove redundant goto
so it matches the history.
> ---
> drivers/pci/p2pdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index fa7370f9561a..a7776315996c 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size)
> if (unlikely(!percpu_ref_tryget_live_rcu(ref))) {
> gen_pool_free(p2pdma->pool, (unsigned long) ret, size);
> ret = NULL;
> - goto out;
> }
> out:
> rcu_read_unlock();
> --
> 2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-23 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-23 8:40 [PATCH] p2pdma: remove redundant goto Tadeusz Struk
2023-10-23 15:51 ` Logan Gunthorpe
2023-10-23 17:19 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox