* [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
@ 2023-10-28 12:22 kernel test robot
2023-10-31 14:56 ` Bjorn Helgaas
0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2023-10-28 12:22 UTC (permalink / raw)
To: Krzysztof Wilczyński ; +Cc: linux-pci
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/xilinx-xdma
branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
Error/Warning ids grouped by kconfigs:
clang_recent_errors
`-- powerpc-pmac32_defconfig
|-- arch-powerpc-sysdev-grackle.c:error:unused-function-grackle_set_stg-Werror-Wunused-function
|-- arch-powerpc-xmon-xmon.c:error:unused-function-get_output_lock-Werror-Wunused-function
`-- arch-powerpc-xmon-xmon.c:error:unused-function-release_output_lock-Werror-Wunused-function
elapsed time: 2656m
configs tested: 144
configs skipped: 2
tested configs:
alpha allnoconfig gcc
alpha allyesconfig gcc
alpha defconfig gcc
arc allmodconfig gcc
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20231027 gcc
arm allmodconfig gcc
arm allnoconfig gcc
arm allyesconfig gcc
arm defconfig gcc
arm gemini_defconfig gcc
arm randconfig-001-20231027 gcc
arm spear13xx_defconfig clang
arm spear6xx_defconfig gcc
arm vf610m4_defconfig gcc
arm64 allmodconfig gcc
arm64 allnoconfig gcc
arm64 allyesconfig gcc
arm64 defconfig gcc
csky allmodconfig gcc
csky allnoconfig gcc
csky allyesconfig gcc
csky defconfig gcc
i386 allnoconfig gcc
i386 buildonly-randconfig-001-20231027 gcc
i386 buildonly-randconfig-002-20231027 gcc
i386 buildonly-randconfig-003-20231027 gcc
i386 buildonly-randconfig-004-20231027 gcc
i386 buildonly-randconfig-005-20231027 gcc
i386 buildonly-randconfig-006-20231027 gcc
i386 debian-10.3 gcc
i386 defconfig gcc
i386 randconfig-006-20231027 gcc
i386 randconfig-011-20231027 gcc
i386 randconfig-012-20231027 gcc
i386 randconfig-013-20231027 gcc
i386 randconfig-014-20231027 gcc
i386 randconfig-015-20231027 gcc
i386 randconfig-016-20231027 gcc
loongarch allmodconfig gcc
loongarch allnoconfig gcc
loongarch allyesconfig gcc
loongarch defconfig gcc
loongarch randconfig-001-20231027 gcc
m68k allmodconfig gcc
m68k allnoconfig gcc
m68k allyesconfig gcc
m68k defconfig gcc
microblaze allmodconfig gcc
microblaze allnoconfig gcc
microblaze allyesconfig gcc
microblaze defconfig gcc
mips allmodconfig gcc
mips allnoconfig clang
mips allnoconfig gcc
mips allyesconfig gcc
mips cobalt_defconfig gcc
mips db1xxx_defconfig gcc
mips maltasmvp_defconfig gcc
mips rs90_defconfig clang
nios2 allmodconfig gcc
nios2 allnoconfig gcc
nios2 allyesconfig gcc
nios2 defconfig gcc
openrisc allmodconfig gcc
openrisc allnoconfig gcc
openrisc allyesconfig gcc
openrisc defconfig gcc
openrisc virt_defconfig gcc
parisc allmodconfig gcc
parisc allnoconfig gcc
parisc allyesconfig gcc
parisc defconfig gcc
parisc64 defconfig gcc
powerpc adder875_defconfig gcc
powerpc akebono_defconfig clang
powerpc allmodconfig gcc
powerpc allnoconfig gcc
powerpc allyesconfig gcc
powerpc mpc836x_rdk_defconfig clang
powerpc pmac32_defconfig clang
powerpc walnut_defconfig clang
riscv defconfig gcc
riscv randconfig-001-20231027 gcc
riscv rv32_defconfig gcc
s390 alldefconfig clang
s390 allnoconfig gcc
s390 allyesconfig gcc
s390 debug_defconfig gcc
s390 defconfig gcc
s390 randconfig-001-20231027 gcc
sh allmodconfig gcc
sh allnoconfig gcc
sh allyesconfig gcc
sh apsh4a3a_defconfig gcc
sh defconfig gcc
sh ecovec24-romimage_defconfig gcc
sh espt_defconfig gcc
sh kfr2r09-romimage_defconfig gcc
sh se7780_defconfig gcc
sparc allmodconfig gcc
sparc allnoconfig gcc
sparc allyesconfig gcc
sparc defconfig gcc
sparc randconfig-001-20231027 gcc
sparc64 allmodconfig gcc
sparc64 allyesconfig gcc
sparc64 defconfig gcc
um allmodconfig clang
um allnoconfig clang
um allyesconfig clang
um defconfig gcc
um i386_defconfig gcc
um x86_64_defconfig gcc
x86_64 allnoconfig gcc
x86_64 allyesconfig gcc
x86_64 buildonly-randconfig-001-20231027 gcc
x86_64 buildonly-randconfig-002-20231027 gcc
x86_64 buildonly-randconfig-003-20231027 gcc
x86_64 buildonly-randconfig-004-20231027 gcc
x86_64 buildonly-randconfig-005-20231027 gcc
x86_64 buildonly-randconfig-006-20231027 gcc
x86_64 defconfig gcc
x86_64 randconfig-001-20231027 gcc
x86_64 randconfig-002-20231027 gcc
x86_64 randconfig-003-20231027 gcc
x86_64 randconfig-004-20231027 gcc
x86_64 randconfig-005-20231027 gcc
x86_64 randconfig-006-20231027 gcc
x86_64 randconfig-011-20231027 gcc
x86_64 randconfig-012-20231027 gcc
x86_64 randconfig-013-20231027 gcc
x86_64 randconfig-014-20231027 gcc
x86_64 randconfig-015-20231027 gcc
x86_64 randconfig-071-20231027 gcc
x86_64 randconfig-072-20231027 gcc
x86_64 randconfig-073-20231027 gcc
x86_64 randconfig-074-20231027 gcc
x86_64 randconfig-075-20231027 gcc
x86_64 randconfig-076-20231027 gcc
x86_64 rhel-8.3-rust clang
x86_64 rhel-8.3 gcc
xtensa common_defconfig gcc
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-10-28 12:22 [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b kernel test robot
@ 2023-10-31 14:56 ` Bjorn Helgaas
2023-10-31 16:24 ` Segher Boessenkool
2023-10-31 16:59 ` Nick Desaulniers
0 siblings, 2 replies; 7+ messages in thread
From: Bjorn Helgaas @ 2023-10-31 14:56 UTC (permalink / raw)
To: kernel test robot
Cc: Krzysztof Wilczyński, linux-pci, Michael Ellerman,
linuxppc-dev, Nathan Chancellor, Nick Desaulniers
[+cc powerpc, clang folks]
On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/xilinx-xdma
> branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
>
> Error/Warning ids grouped by kconfigs:
>
> clang_recent_errors
> `-- powerpc-pmac32_defconfig
> |-- arch-powerpc-sysdev-grackle.c:error:unused-function-grackle_set_stg-Werror-Wunused-function
> |-- arch-powerpc-xmon-xmon.c:error:unused-function-get_output_lock-Werror-Wunused-function
> `-- arch-powerpc-xmon-xmon.c:error:unused-function-release_output_lock-Werror-Wunused-function
This report is close to useless. It doesn't show the complete error
message, it doesn't show how to reproduce the issue, and the pci -next
branch (including controller/xilinx-xdma) doesn't reference any of
these functions:
$ git grep -E "grackle_set_stg|get_output_lock|release_output_lock" | cat
arch/powerpc/sysdev/grackle.c:static inline void grackle_set_stg(struct pci_controller* bp, int enable)
arch/powerpc/sysdev/grackle.c: grackle_set_stg(hose, 1);
arch/powerpc/xmon/xmon.c:static void get_output_lock(void)
arch/powerpc/xmon/xmon.c:static void release_output_lock(void)
arch/powerpc/xmon/xmon.c:static inline void get_output_lock(void) {}
arch/powerpc/xmon/xmon.c:static inline void release_output_lock(void) {}
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
That said, the unused functions do look legit:
grackle_set_stg() is a static function and the only call is under
"#if 0".
Same with get_output_lock() and release_output_lock(): they're static
and always defined in xmon.c, but only called if either CONFIG_SMP or
CONFIG_DEBUG_FS.
But they're certainly not related to controller/xilinx-xdma, so I'm
going to ignore them.
Bjorn
P.S. Nathan & Nick, I cc'd you because of this earlier report that
also mentioned grackle_set_stg():
https://lore.kernel.org/lkml/202308121120.u2d3YPVt-lkp@intel.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-10-31 14:56 ` Bjorn Helgaas
@ 2023-10-31 16:24 ` Segher Boessenkool
2023-10-31 16:59 ` Nick Desaulniers
1 sibling, 0 replies; 7+ messages in thread
From: Segher Boessenkool @ 2023-10-31 16:24 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: kernel test robot, linux-pci, Nick Desaulniers, Nathan Chancellor,
linuxppc-dev, Krzysztof Wilczyński
On Tue, Oct 31, 2023 at 09:56:00AM -0500, Bjorn Helgaas wrote:
> That said, the unused functions do look legit:
>
> grackle_set_stg() is a static function and the only call is under
> "#if 0".
It is a static inline. It is *normal* that that is uncalled. It is
very similar to a macro that has no invocation. The warning is
overeager.
Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-10-31 14:56 ` Bjorn Helgaas
2023-10-31 16:24 ` Segher Boessenkool
@ 2023-10-31 16:59 ` Nick Desaulniers
2023-10-31 17:14 ` Bjorn Helgaas
1 sibling, 1 reply; 7+ messages in thread
From: Nick Desaulniers @ 2023-10-31 16:59 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: kernel test robot, Krzysztof Wilczyński, linux-pci,
Michael Ellerman, linuxppc-dev, Nathan Chancellor, Arnd Bergmann
On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> [+cc powerpc, clang folks]
>
> On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/xilinx-xdma
> > branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
> >
> > Error/Warning ids grouped by kconfigs:
> >
> > clang_recent_errors
> > `-- powerpc-pmac32_defconfig
> > |-- arch-powerpc-sysdev-grackle.c:error:unused-function-grackle_set_stg-Werror-Wunused-function
> > |-- arch-powerpc-xmon-xmon.c:error:unused-function-get_output_lock-Werror-Wunused-function
> > `-- arch-powerpc-xmon-xmon.c:error:unused-function-release_output_lock-Werror-Wunused-function
>
> This report is close to useless. It doesn't show the complete error
> message, it doesn't show how to reproduce the issue, and the pci -next
> branch (including controller/xilinx-xdma) doesn't reference any of
> these functions:
>
> $ git grep -E "grackle_set_stg|get_output_lock|release_output_lock" | cat
> arch/powerpc/sysdev/grackle.c:static inline void grackle_set_stg(struct pci_controller* bp, int enable)
> arch/powerpc/sysdev/grackle.c: grackle_set_stg(hose, 1);
> arch/powerpc/xmon/xmon.c:static void get_output_lock(void)
> arch/powerpc/xmon/xmon.c:static void release_output_lock(void)
> arch/powerpc/xmon/xmon.c:static inline void get_output_lock(void) {}
> arch/powerpc/xmon/xmon.c:static inline void release_output_lock(void) {}
> arch/powerpc/xmon/xmon.c: get_output_lock();
> arch/powerpc/xmon/xmon.c: release_output_lock();
> arch/powerpc/xmon/xmon.c: get_output_lock();
> arch/powerpc/xmon/xmon.c: release_output_lock();
> arch/powerpc/xmon/xmon.c: get_output_lock();
> arch/powerpc/xmon/xmon.c: release_output_lock();
> arch/powerpc/xmon/xmon.c: get_output_lock();
> arch/powerpc/xmon/xmon.c: release_output_lock();
>
> That said, the unused functions do look legit:
>
> grackle_set_stg() is a static function and the only call is under
> "#if 0".
Time to remove it then? Or is it a bug that it's not called?
Otherwise the definition should be behind the same preprocessor guards
as the caller. Same for the below.
>
> Same with get_output_lock() and release_output_lock(): they're static
> and always defined in xmon.c, but only called if either CONFIG_SMP or
> CONFIG_DEBUG_FS.
>
> But they're certainly not related to controller/xilinx-xdma, so I'm
> going to ignore them.
>
> Bjorn
>
> P.S. Nathan & Nick, I cc'd you because of this earlier report that
> also mentioned grackle_set_stg():
> https://lore.kernel.org/lkml/202308121120.u2d3YPVt-lkp@intel.com/
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-10-31 16:59 ` Nick Desaulniers
@ 2023-10-31 17:14 ` Bjorn Helgaas
2023-11-01 9:25 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Helgaas @ 2023-10-31 17:14 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Arnd Bergmann, kernel test robot, Nathan Chancellor, linux-pci,
linuxppc-dev, Krzysztof Wilczyński
On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote:
> On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/xilinx-xdma
> > > branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
> > >
> > > Error/Warning ids grouped by kconfigs:
> > >
> > > clang_recent_errors
> > > `-- powerpc-pmac32_defconfig
> > > |-- arch-powerpc-sysdev-grackle.c:error:unused-function-grackle_set_stg-Werror-Wunused-function
> > > |-- arch-powerpc-xmon-xmon.c:error:unused-function-get_output_lock-Werror-Wunused-function
> > > `-- arch-powerpc-xmon-xmon.c:error:unused-function-release_output_lock-Werror-Wunused-function
> >
> > This report is close to useless. It doesn't show the complete error
> > message, it doesn't show how to reproduce the issue, and the pci -next
> > branch (including controller/xilinx-xdma) doesn't reference any of
> > these functions:
> >
> > $ git grep -E "grackle_set_stg|get_output_lock|release_output_lock" | cat
> > arch/powerpc/sysdev/grackle.c:static inline void grackle_set_stg(struct pci_controller* bp, int enable)
> > arch/powerpc/sysdev/grackle.c: grackle_set_stg(hose, 1);
> > arch/powerpc/xmon/xmon.c:static void get_output_lock(void)
> > arch/powerpc/xmon/xmon.c:static void release_output_lock(void)
> > arch/powerpc/xmon/xmon.c:static inline void get_output_lock(void) {}
> > arch/powerpc/xmon/xmon.c:static inline void release_output_lock(void) {}
> > arch/powerpc/xmon/xmon.c: get_output_lock();
> > arch/powerpc/xmon/xmon.c: release_output_lock();
> > arch/powerpc/xmon/xmon.c: get_output_lock();
> > arch/powerpc/xmon/xmon.c: release_output_lock();
> > arch/powerpc/xmon/xmon.c: get_output_lock();
> > arch/powerpc/xmon/xmon.c: release_output_lock();
> > arch/powerpc/xmon/xmon.c: get_output_lock();
> > arch/powerpc/xmon/xmon.c: release_output_lock();
> >
> > That said, the unused functions do look legit:
> >
> > grackle_set_stg() is a static function and the only call is under
> > "#if 0".
>
> Time to remove it then? Or is it a bug that it's not called?
> Otherwise the definition should be behind the same preprocessor guards
> as the caller. Same for the below.
I don't really care whether we keep the warning or not.
My real complaint is that the 0-day report fingered
pci/controller/xilinx-xdma, which is completely unrelated, which is a
waste of time.
> > Same with get_output_lock() and release_output_lock(): they're static
> > and always defined in xmon.c, but only called if either CONFIG_SMP or
> > CONFIG_DEBUG_FS.
> >
> > But they're certainly not related to controller/xilinx-xdma, so I'm
> > going to ignore them.
> >
> > Bjorn
> >
> > P.S. Nathan & Nick, I cc'd you because of this earlier report that
> > also mentioned grackle_set_stg():
> > https://lore.kernel.org/lkml/202308121120.u2d3YPVt-lkp@intel.com/
>
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-10-31 17:14 ` Bjorn Helgaas
@ 2023-11-01 9:25 ` Arnd Bergmann
2023-11-01 17:34 ` Nathan Chancellor
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2023-11-01 9:25 UTC (permalink / raw)
To: Bjorn Helgaas, Nick Desaulniers
Cc: kernel test robot, linux-pci, Nathan Chancellor, linuxppc-dev,
Krzysztof Wilczyński
On Tue, Oct 31, 2023, at 18:14, Bjorn Helgaas wrote:
> On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote:
>> On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>> > arch/powerpc/xmon/xmon.c: release_output_lock();
>> >
>> > That said, the unused functions do look legit:
>> >
>> > grackle_set_stg() is a static function and the only call is under
>> > "#if 0".
>>
>> Time to remove it then? Or is it a bug that it's not called?
>> Otherwise the definition should be behind the same preprocessor guards
>> as the caller. Same for the below.
It would be nice to get rid of all warnings about unused
"static inline" functions and "static const" variables in .c
files. I think both these warnings got added at the W=1 level
for compilers that support them at some point, but are ignored
for normal builds without W=1 because they are too noisy.
Obviously, all compilers ignore unused inline functions and
const variables in header files regardless of the warning level.
> I don't really care whether we keep the warning or not.
>
> My real complaint is that the 0-day report fingered
> pci/controller/xilinx-xdma, which is completely unrelated, which is a
> waste of time.
I tried to figure this out but couldn't find the real reason either,
clearly there is something wrong with the reporting here, my best
guess would be that there is a spurious build failure elsewhere that
leads to this file sometimes getting flagged as a false-positive.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
2023-11-01 9:25 ` Arnd Bergmann
@ 2023-11-01 17:34 ` Nathan Chancellor
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Chancellor @ 2023-11-01 17:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Helgaas, Nick Desaulniers, kernel test robot, linux-pci,
linuxppc-dev, Krzysztof Wilczyński
On Wed, Nov 01, 2023 at 10:25:25AM +0100, Arnd Bergmann wrote:
> On Tue, Oct 31, 2023, at 18:14, Bjorn Helgaas wrote:
> > On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote:
> >> On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> >> > arch/powerpc/xmon/xmon.c: release_output_lock();
> >> >
> >> > That said, the unused functions do look legit:
> >> >
> >> > grackle_set_stg() is a static function and the only call is under
> >> > "#if 0".
> >>
> >> Time to remove it then? Or is it a bug that it's not called?
> >> Otherwise the definition should be behind the same preprocessor guards
> >> as the caller. Same for the below.
>
> It would be nice to get rid of all warnings about unused
> "static inline" functions and "static const" variables in .c
> files. I think both these warnings got added at the W=1 level
> for compilers that support them at some point, but are ignored
> for normal builds without W=1 because they are too noisy.
>
> Obviously, all compilers ignore unused inline functions and
> const variables in header files regardless of the warning level.
Right, this was an intentional change done by Masahiro to try and take
advantage of the fact that clang warns about unused static inline
functions in .c files (whereas GCC has no warning in .c or .h files) to
clean up dead code. See commit 6863f5643dd7 ("kbuild: allow Clang to
find unused static inline functions for W=1 build") for more
information.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-11-01 17:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-28 12:22 [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b kernel test robot
2023-10-31 14:56 ` Bjorn Helgaas
2023-10-31 16:24 ` Segher Boessenkool
2023-10-31 16:59 ` Nick Desaulniers
2023-10-31 17:14 ` Bjorn Helgaas
2023-11-01 9:25 ` Arnd Bergmann
2023-11-01 17:34 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox