From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <nks@flawful.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: dwc: endpoint: Fix dw_pcie_ep_raise_msix_irq() alignment support
Date: Mon, 18 Dec 2023 10:12:40 +0900 [thread overview]
Message-ID: <20231218011240.GA88933@rocinante> (raw)
In-Reply-To: <20231128132231.2221614-1-nks@flawful.org>
Hello,
> Commit 6f5e193bfb55 ("PCI: dwc: Fix dw_pcie_ep_raise_msix_irq() to get
> correct MSI-X table address") modified dw_pcie_ep_raise_msix_irq() to
> support iATUs which require a specific alignment.
>
> However, this support cannot have been properly tested.
>
> The whole point is for the iATU to map an address that is aligned,
> using dw_pcie_ep_map_addr(), and then let the writel() write to
> ep->msi_mem + aligned_offset.
>
> Thus, modify the address that is mapped such that it is aligned.
> With this change, dw_pcie_ep_raise_msix_irq() matches the logic in
> dw_pcie_ep_raise_msi_irq().
Applied to controller/dwc, thank you!
[1/1] PCI: dwc: endpoint: Fix dw_pcie_ep_raise_msix_irq() alignment support
https://git.kernel.org/pci/pci/c/2217fffcd63f
Krzysztof
next prev parent reply other threads:[~2023-12-18 1:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 13:22 [PATCH v2] PCI: dwc: endpoint: Fix dw_pcie_ep_raise_msix_irq() alignment support Niklas Cassel
2023-11-28 16:21 ` Manivannan Sadhasivam
2023-12-14 9:59 ` Niklas Cassel
2023-12-18 1:17 ` Krzysztof Wilczyński
2023-12-18 1:12 ` Krzysztof Wilczyński [this message]
2023-12-26 22:17 ` Bjorn Helgaas
2023-12-27 11:57 ` Niklas Cassel
2023-12-27 13:03 ` Bjorn Helgaas
2024-01-02 16:48 ` Manivannan Sadhasivam
2024-01-02 10:25 ` Kishon Vijay Abraham I
2024-01-03 6:03 ` Kishon Vijay Abraham I
2024-01-09 12:52 ` Niklas Cassel
2024-01-02 15:54 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218011240.GA88933@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=nks@flawful.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox